From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH v2 2/2] Add Rust support to source highlighting
Date: Thu, 19 Sep 2019 12:54:00 -0000 [thread overview]
Message-ID: <87woe4saz0.fsf@tromey.com> (raw)
In-Reply-To: <44701c2c-21a7-0211-cc45-b6214ecfb165@suse.de> (Tom de Vries's message of "Thu, 19 Sep 2019 00:15:48 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Well, it does work, but your question makes me realize that that's an
Tom> implementation artefact of the library, which could change for newer
Tom> version (or perhaps there are older versions where that differs). So it
Tom> should be safer to wrap highlighter construction as well.
Tom> Updated the patch accordingly, and also added a PR number to both patches.
Looks good to me -- but the bad news is you'll probably now want a
similar patch on master.
thanks,
Tom
next prev parent reply other threads:[~2019-09-19 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 15:52 [PATCH v2 0/2] " Tom Tromey
2019-07-27 15:52 ` [PATCH v2 2/2] " Tom Tromey
2019-09-04 17:22 ` Tom de Vries
2019-09-10 15:56 ` Tom Tromey
2019-09-12 19:20 ` Tom de Vries
2019-09-17 18:24 ` Tom Tromey
2019-09-18 22:16 ` Tom de Vries
2019-09-19 12:54 ` Tom Tromey [this message]
2019-09-19 16:18 ` [PATCH][gdb] Catch exception when constructing the highlighter Tom de Vries
2019-07-27 15:52 ` [PATCH v2 1/2] Add --with-static-standard-libraries to the top level Tom Tromey
2019-08-19 16:19 ` [PATCH v2 0/2] Add Rust support to source highlighting Tom Tromey
2019-08-19 18:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woe4saz0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox