From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106652 invoked by alias); 20 Sep 2019 19:15:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106644 invoked by uid 89); 20 Sep 2019 19:15:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=sk:some_ki, sk:catch_e, UD:catch_ex_std.exp X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.139) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Sep 2019 19:15:55 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id AEF33841585 for ; Fri, 20 Sep 2019 14:15:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BONliZMbq3Qi0BONliADb0; Fri, 20 Sep 2019 14:15:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hA/P/u+O2r1ZGoDtdeRBxb02I6ittCZMjTZZqHsZteo=; b=Q0h8jsfP/KWE5pcw31nYZAAxLP LwOk1HLeOu6NEMKyzeyI12ien8sX92yHRSDb2WxkU0kxPmgSXW9qdX8a5Bu8CoFMLRA/9b96OvBvn Fl0GfneMNvNWAWiWv27wIDbVR; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:49194 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iBONl-003y3F-Dv; Fri, 20 Sep 2019 14:15:53 -0500 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 7/8] Add $_ada_exception convenience variable References: <20190801170412.5553-1-tromey@adacore.com> <20190801170412.5553-8-tromey@adacore.com> <20190827094702.GN6076@embecosm.com> Date: Fri, 20 Sep 2019 19:15:00 -0000 In-Reply-To: <20190827094702.GN6076@embecosm.com> (Andrew Burgess's message of "Tue, 27 Aug 2019 10:47:02 +0100") Message-ID: <87woe2pymv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00404.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: >> +gdb_test "print \$_ada_exception = some_package.some_kind_of_error'Address" \ >> + " = true" Andrew> When I ran these tests I noticed that this new test was failing for Andrew> me. It turns out that a previous test in this file already fails for Andrew> me, like this: Andrew> (gdb) catch exception some_kind_of_error Andrew> Your Ada runtime appears to be missing some debugging information. Andrew> Cannot insert Ada exception catchpoint in this configuration. Andrew> (gdb) FAIL: gdb.ada/catch_ex_std.exp: catch exception some_kind_of_error Andrew> And as a result, the new test will also fail. Andrew> I suspect there's probably a package I should be installing to resolve Andrew> this issue, but I put together the patch below that spots the above Andrew> warning and reports UNSUPPORTED rather than FAIL. I don't know if Andrew> this is something you feel is worth including or not? Andrew> Obviously I've only confirmed that the UNSUPPORTED path through the Andrew> code works, so you'd need to test the PASS path for me. Thanks. This does still work for me. I think you should check it in. Maybe it's also needed by catch_ex.exp? Tom