From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96648 invoked by alias); 11 Oct 2019 17:46:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96640 invoked by uid 89); 11 Oct 2019 17:46:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:724 X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.64.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Oct 2019 17:46:05 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 513DC400E28BC for ; Fri, 11 Oct 2019 11:38:48 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IyzMic8DVBnGaIyzMikaIS; Fri, 11 Oct 2019 12:46:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D/lz03khQGCmjfGer8kRkfTVXb9G11BevdUZr0IX1ic=; b=SMJ+FIfVGd7bWOSic6aw8s/dvY A7mnhvMzjWiFdTUWgic4Od30CWrHEH06VwLfP+ECO/HGFOr7b9nLwvIjS9nGvF9w+uzYayQd5A2fG p3MXwvhk1XH1v2vFNL07Egu2j; Received: from 174-29-53-230.hlrn.qwest.net ([174.29.53.230]:41666 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iIyzM-0039o1-6J; Fri, 11 Oct 2019 11:46:04 -0600 From: Tom Tromey To: Andreas Arnez Cc: gdb-patches@sourceware.org, Ulrich Weigand Subject: Re: [PATCH] s390: Fix infcalls passing a single-field struct with static members References: Date: Fri, 11 Oct 2019 17:46:00 -0000 In-Reply-To: (Andreas Arnez's message of "Fri, 11 Oct 2019 16:49:50 +0200") Message-ID: <87wodb2n1h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00300.txt.bz2 >>>>> "Andreas" == Andreas Arnez writes: Andreas> The infcall-nested-structs test case yields 36 FAILs on s390x because GCC Andreas> and GDB disagree on how to pass a C++ struct like this as an argument to a Andreas> function: Andreas> struct s { float x; static float y; }; Andreas> For the purpose of argument passing, GCC ignores static fields, while GDB Andreas> does not. Thus GCC passes the argument in a floating-point register and Andreas> GDB passes it via memory. Andreas> Fix this by explicitly ignoring static fields when detecting single-field Andreas> structs. FWIW this looked reasonable to me. Tom