From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55820 invoked by alias); 28 Feb 2020 15:29:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55811 invoked by uid 89); 28 Feb 2020 15:29:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=ugly X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.149.4) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 15:29:43 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 6AAAD1C1C6 for ; Fri, 28 Feb 2020 09:29:42 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7haAjLNV7RP4z7haAjjldj; Fri, 28 Feb 2020 09:29:42 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z4xYLsDLQGMafIqKLkb3VNF8bsRnE5y3FeAXaO0wjUM=; b=MOqjqxu7b4eEfuk/1QBRoIiwh1 hDfdR7JirKIKfijrlqCedS21wga+YX9YYJFF8Lz363H9mdt6lzNkOkVyUQOilMstfbZTfxOdDzbjv XbEPwpLfPI6vkVwdcoGVrjUrh; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:38670 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j7haA-003q5d-4g; Fri, 28 Feb 2020 08:29:42 -0700 From: Tom Tromey To: Sergio Durigan Junior Cc: GDB Patches , Pedro Alves , Tom Tromey , Eli Zaretskii , Ruslan Kabatsayev Subject: Re: [PATCH 2/6] Don't reset errno/bfd_error on 'throw_perror_with_name' References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> <20200226200542.746617-3-sergiodj@redhat.com> Date: Fri, 28 Feb 2020 15:29:00 -0000 In-Reply-To: <20200226200542.746617-3-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Wed, 26 Feb 2020 15:05:38 -0500") Message-ID: <87wo86ivbu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg01059.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> Since this hunk may be a bit controversial, I decided to split it into Sergio> a separate patch. This is going to be needed by the ptrace-error Sergio> feature; GDB will need to be able to access the value of errno even Sergio> after a call to our 'perror'-like functions. I'm in favor of this. The existing code seems pretty ugly. I'd imagine it's unlikely that any caller would rely on this. If it tested cleanly then that is good enough for me. Sergio> Another small hunk is the one that saves/restores errno on gdbserver's Sergio> 'perror_with_name', but this one is pretty trivial, I think. I didn't understand why this one was needed. Does safe_strerror reset errno? Maybe a comment would be in order. Tom