From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.23]) by sourceware.org (Postfix) with ESMTPS id 4866D385DC00 for ; Sat, 4 Apr 2020 14:23:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4866D385DC00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id D32CC1B282E for ; Sat, 4 Apr 2020 09:23:32 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Kjhsjv2gcEfyqKjhsjr5Pn; Sat, 04 Apr 2020 09:23:32 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+SzQmiviRmW1kx1aoAbCX/+ceKHNZhddU01yM2+1+dI=; b=nPrilYuhgINJkYE7avjm/j1WlL AXSqRwuahSTQyFSPimEdF3ViBoNoTznf/6oyG3N0uMvTFnNoXSvd9tcEsFPKj5+6gioJr47b+iNse epu1tVLRmZk/ulXyyB82cV0Xs; Received: from 174-16-110-145.hlrn.qwest.net ([174.16.110.145]:53092 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jKjhs-003XyW-Jx; Sat, 04 Apr 2020 08:23:32 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 16/20] Change is_valid_DW_AT_defaulted to a method on attribute References: <20200328192208.11324-1-tom@tromey.com> <20200328192208.11324-17-tom@tromey.com> X-Attribution: Tom Date: Sat, 04 Apr 2020 08:23:31 -0600 In-Reply-To: (Simon Marchi's message of "Mon, 30 Mar 2020 12:00:29 -0400") Message-ID: <87wo6vs524.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.110.145 X-Source-L: No X-Exim-ID: 1jKjhs-003XyW-Jx X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-110-145.hlrn.qwest.net (bapiya) [174.16.110.145]:53092 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2020 14:23:34 -0000 >>>>> "Simon" == Simon Marchi writes: >> + if (form_is_constant ()) >> + complaint (_("unrecognized DW_AT_defaulted value (%s)"), >> + plongest (value)); >> + return DW_DEFAULTED_no; Simon> I don't quite understand the logic here, we check Simon> form_is_constant after having called constant_value? If the form Simon> is not a constant, shouldn't we emit a warning to that effect Simon> (and return _no)? In this case the complaint is issued by constant_value. This avoids duplicate complaints. I will make a note to this effect. >> + /* Return the value as one of the recognized enum >> + dwarf_defaulted_attribute constants according to DWARF5 spec, >> + Table 7.24. If the value is incorrect, or if this attribute has >> + the wrong form, then a complaint is issued and DW_DEFAULTED_no is >> + returned. */ >> + dwarf_defaulted_attribute defaulted () const; >> + Simon> There's an extra empty line here, might as well remove it. I often leave space between the methods and the data members, but I suppose I don't really care that much. It would be better to add "private:" but that requires another round of patching. Tom