From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH][gdb/symtab] Add symbol with inherited DW_AT_const_value to psymtabs
Date: Tue, 07 Apr 2020 09:28:42 -0600 [thread overview]
Message-ID: <87wo6r5n85.fsf@tromey.com> (raw)
In-Reply-To: <e721be1b-698e-af9c-18dd-22e32649f793@suse.de> (Tom de Vries's message of "Tue, 7 Apr 2020 16:54:27 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>> My main concern is not to make psymbol reading any slower than it
>> already is.
Tom> Still faster than -readnow though, I hope :)
Yeah :)
And correctness still comes first, I would just rather things not slip
backward.
Tom> 2020-04-07 Tom de Vries <tdevries@suse.de>
Tom> PR symtab/25796
Tom> * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
Tom> (partial_die_info::fixup): Inherit has_const_value.
Tom> gdb/testsuite/ChangeLog:
Tom> 2020-04-07 Tom de Vries <tdevries@suse.de>
Tom> PR symtab/25796
Tom> * gdb.dwarf2/imported-unit-abstract-const-value.exp: New file.
Looks good, thank you.
Tom
prev parent reply other threads:[~2020-04-07 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 11:59 Tom de Vries
2020-04-07 13:09 ` Tom Tromey
2020-04-07 14:54 ` Tom de Vries
2020-04-07 15:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo6r5n85.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox