Re: [PATCH v2 00/42] Share DWARF partial symtabs between objfiles

Tom Tromey
2020-05-22T21:07:37Z

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> The big difference between v1 and v2 is how the split is done.
[...]

Thank you so much for doing this. This is a big improvement over the
approach I took.

I read through the patches. It was difficult to do without glazing over
a bit, so I'm not sure I really did a good job. However, I'm
comfortable with the direction you've taken here.

Simon> Before: Command execution time: 1.213480 (cpu), 1.214268 (wall)
Simon> After: Command execution time: 0.001697 (cpu), 0.001694 (wall)

Simon> These are the times of one run, but all runs I did are very close. The "after"
Simon> time is surpringly low compared to the original numbers, I hope it doesn't mean
Simon> I messed up something and we are skipping something important...

I doubt it, more like with the new approach, there just isn't much work
to be done in this case.

Simon> At some point I tested with all these boards and did not see any regression
Simon> (they helped very much to find some issues in the process though):

Simon> unix cc-with-debug-names cc-with-dwz cc-with-dwz-m cc-with-gdb-index dwarf4-gdb-index fission-dwp fission readnow

Stellar.

Tom