Re: [PATCH v2 00/42] Share DWARF partial symtabs between objfiles

Simon Marchi
2020-05-25T19:56:07Z

On 2020-05-23 8:24 a.m., Pedro Alves wrote:
> On 5/22/20 10:07 PM, Tom Tromey wrote:
>>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Simon> The big difference between v1 and v2 is how the split is done.
>> [...]
>>
>> Thank you so much for doing this. This is a big improvement over the
>> approach I took.
>>
>> I read through the patches. It was difficult to do without glazing over
>> a bit, so I'm not sure I really did a good job. However, I'm
>> comfortable with the direction you've taken here.
>
> I skimmed through the patches, glazing over a lot. The direction seems
> good to me too, FWIW.
>
> Just wanted to say, kudos for continuing this effort, and thanks for all
> the work.
>
> Pedro Alves
>

I posted the complete version of patch 15/42 (it was missing the commit
message).

Other than that, does any of you have further comments? I've done the
small suggested fixups, but I don't think there was anything big
requiring another round, is there?

Simon