From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.36]) by sourceware.org (Postfix) with ESMTPS id D2C89395CC23 for ; Wed, 27 May 2020 15:07:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D2C89395CC23 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 7A7E94364E for ; Wed, 27 May 2020 10:07:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dxeAj3bCEXVkQdxeAj62S1; Wed, 27 May 2020 10:07:10 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ssz3H9+6MzBddg6D4yIngJv+3cvyH5OkkaW+445aX+0=; b=QhdQGEOt3dz8unH8D+warThoXI /gvVApzdonTEIXTCXSSm8oV5IwYkDYpDYjICT0bt1i1nS2aorqOB2635T+sAIgcvowua85PagtJUW EhVNQ2Xruio/Pxq7LlA0k6mPS; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:45242 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jdxeA-003ly3-68; Wed, 27 May 2020 09:07:10 -0600 From: Tom Tromey To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 41.5/42] Move line_header_hash to dwarf2_per_objfile References: <20200512210913.5593-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 27 May 2020 09:07:09 -0600 In-Reply-To: (Simon Marchi's message of "Wed, 27 May 2020 10:50:14 -0400") Message-ID: <87wo4xpgbm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jdxeA-003ly3-68 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:45242 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2020 15:07:12 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> The `line_header_hash` field of `struct dwarf2_per_bfd` contains some Simon> `struct line_header` objects. A `struct line_header` objects contains Simon> some `file_entry` objects. A `file_entry` object contains a pointer to Simon> the `symtab` object created from it. The `line_header_hash` is Simon> therefore ultimately objfile-dependent and can't be shared as-is between Simon> objfiles. Simon> Move it from `dwarf2_per_bfd` to `dwarf2_per_objfile`. This patch looks good. I wonder how hard it would be to remove this symtab link and share these across objfiles. However, I don't think this is worth delaying the series for. Tom