From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.234]) by sourceware.org (Postfix) with ESMTPS id AC402394742E for ; Thu, 11 Jun 2020 13:55:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AC402394742E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id DAE7A523A for ; Thu, 11 Jun 2020 08:55:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id jNfnj1pTvhmVTjNfnjveLn; Thu, 11 Jun 2020 08:55:15 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hb67McCgaDGa+jjY6lBDYG5PRe9Omcqed5ZSf1OuX6M=; b=JTUEH/FT/jOWX4IffpDNSKu9Gv f+CsZRcCo+sI0bPY0ViLhjSaVZ9pyeor2z4scWsQg38wPNfptUWirsK8HqLkM4WXBgkVCN1UOFq/C NUAViFPhI+vg5VqsCuczXXpXF; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:33060 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jjNfm-000kuU-E9; Thu, 11 Jun 2020 07:55:14 -0600 From: Tom Tromey To: Tom de Vries Cc: Pedro Alves , Andrew Burgess , gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH][gdb/testsuite] Don't leak tuiterm.exp spawn override References: <20200519163004.GA9045@delia> <20200602153830.GZ3522@embecosm.com> <72b3c10c-d316-9a0e-13e9-56dee7c765a7@redhat.com> <5d6277ac-76ea-5f47-ab9e-7da58fbddd6e@suse.de> <66a24a94-3492-7667-58c5-3c0e1330cea1@suse.de> X-Attribution: Tom Date: Thu, 11 Jun 2020 07:55:13 -0600 In-Reply-To: <66a24a94-3492-7667-58c5-3c0e1330cea1@suse.de> (Tom de Vries's message of "Fri, 5 Jun 2020 12:06:39 +0200") Message-ID: <87wo4dvha6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jjNfm-000kuU-E9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:33060 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 13:55:18 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> This fix uses a load_lib override. Tom> Any comments? There was a report recently about gdb overrides like this breaking with a newer dejagnu. Maybe we need a gdb_load or something like that, instead of monkey-patching dejagnu? Or some other different approach. I'm not really opposed to this FWIW. It seems not likely to cause problems. Though I thought that about the other override too, so.. Tom