From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.78]) by sourceware.org (Postfix) with ESMTPS id 4C0BC38708A4 for ; Thu, 18 Jun 2020 16:01:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4C0BC38708A4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id C8369DC4EA for ; Thu, 18 Jun 2020 11:00:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lwyIjan9yQyTQlwyIjotNp; Thu, 18 Jun 2020 11:00:58 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Y9fFtc69wv6yij3yC2EztQI4TKbo0kN2q7QcTnDWGug=; b=xWvvEN3xY8JPtaacj7S1BF8wBV KVDk3aQ2aw6vv+77Yb5Q2OEDCjqMJW7sECeoc0AMpUbbZRcgm/CP9FSFKBI+C7CHcbfBa5VcPCV5J sz86ypBB7k8/8rxwA+76JS5yV; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:54622 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jlwyI-001QlH-35; Thu, 18 Jun 2020 10:00:58 -0600 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , tromey@adacore.com, gdb-patches@sourceware.org, palves@redhat.com Subject: Re: [PATCH 2/3] Consistently use BFD's time References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-3-tromey@adacore.com> <83wo9s4sac.fsf@gnu.org> <87k1044g1x.fsf@tromey.com> <83r1ucza8u.fsf@gnu.org> X-Attribution: Tom Date: Thu, 18 Jun 2020 10:00:57 -0600 In-Reply-To: <83r1ucza8u.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Jun 2020 18:04:01 +0300") Message-ID: <87wo442wjq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jlwyI-001QlH-35 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:54622 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 16:01:03 -0000 >>>>> "Eli" == Eli Zaretskii writes: Eli> I meant a different part of Gnulib's sys/stat.h: Thanks. Eli> AFAICT, gnulib/import/m4/stat.m4 does that for MinGW unconditionally: Eli> case "$host_os" in Eli> mingw*) Eli> dnl On this platform, the original stat() returns st_atime, st_mtime, Eli> dnl st_ctime values that are affected by the time zone. Eli> REPLACE_STAT=1 Eli> ;; Eli> So the way to avoid the replacement is to modify this test, right? I tried that, but unfortunately I think it didn't really work -- gnulib still builds and uses _gl_convert_FILETIME_to_POSIX and _gl_fstat_by_handle. I considered two other approaches: 1. Link BFD and binutils against gnulib. This seems like a pain because at least Fedora installs libbfd.so, so we'd either have to arrange to build a gnulib.so (I guess under some other name) or get the gnulib objects into the shared libbfd... ugh. 2. Use --avoid=stat --avoid=fstat. So far this seems like the best approach. Pedro pointed out that this means we won't get any gnulib fixes for other bugs in this area. However, given gdb's relatively minimal needs from stat, and given the fact that gnulib is introducing other bugs, this seems like an acceptable tradeoff to me. Tom