From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mMYACsNpHWC0IwAAWB0awg (envelope-from ) for ; Fri, 05 Feb 2021 10:52:35 -0500 Received: by simark.ca (Postfix, from userid 112) id 270A71EFCB; Fri, 5 Feb 2021 10:52:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 87DB81E939 for ; Fri, 5 Feb 2021 10:52:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD413386F009; Fri, 5 Feb 2021 15:52:33 +0000 (GMT) Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.64.36]) by sourceware.org (Postfix) with ESMTPS id D9FD3386F009 for ; Fri, 5 Feb 2021 15:52:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D9FD3386F009 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 24583400F61C5 for ; Fri, 5 Feb 2021 09:45:14 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 83PIlXJ4jsvw983PIleCkm; Fri, 05 Feb 2021 09:52:28 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XZ9MEMPcWlML2RW9PqDKgGHihtatC+gf5sRMlKeqo4E=; b=RifKwqhm9IoaQ9cyDYmnG5Ftul Jxs0aVFDNcBneKECQkbTJWxl7P4+BZmQm9M4nPYETwGscWJFVw4hnBHP+IsY3YcBhJm0jijsbC/Ma jfIwyo0kOQv4+JzW4zw0o/69x; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:42326 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l83PI-003JTJ-Kw; Fri, 05 Feb 2021 08:52:28 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [PATCH][gdb/breakpoints] Fix segfault for catch syscall -1 References: <20210202081351.GA28768@delia> X-Attribution: Tom Date: Fri, 05 Feb 2021 08:52:27 -0700 In-Reply-To: <20210202081351.GA28768@delia> (Tom de Vries's message of "Tue, 2 Feb 2021 09:13:52 +0100") Message-ID: <87wnvm4imc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l83PI-003JTJ-Kw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:42326 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> PR breakpoints/27313 Tom> * break-catch-syscall.c (catch_syscall_split_args): Reject negative Tom> syscall numbers. Looks good. Thank you for doing this. Tom> + if (syscall_number < 0) Tom> + error (_("Unknown syscall number '%d'."), syscall_number); Does syscall_number==0 make sense? Tom