From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BRtAJbroImAWaAAAWB0awg (envelope-from ) for ; Tue, 09 Feb 2021 14:55:38 -0500 Received: by simark.ca (Postfix, from userid 112) id 8A2F71EF4F; Tue, 9 Feb 2021 14:55:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 27CCE1E590 for ; Tue, 9 Feb 2021 14:55:38 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7B6D23858002; Tue, 9 Feb 2021 19:55:37 +0000 (GMT) Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.175]) by sourceware.org (Postfix) with ESMTPS id 534F5385041A for ; Tue, 9 Feb 2021 19:55:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 534F5385041A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 7F93B4014A414 for ; Tue, 9 Feb 2021 13:54:47 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9Z5zlqUP3HPnU9Z5zlMyCt; Tue, 09 Feb 2021 13:54:47 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n/U2jmwrvygFkAsKeLjy8LK+sh8wYFjr7EjrIVZggzA=; b=JIuSa9piNiwiZHCx6HDmQY1lPD ht6LfqPTe94mNqP1SDWzFCbXy/55o8Z8uqK+ghHByr4koFhP2yrdS4HgKX4u6K03uzU9T3c0hh+lm Hi8J3QcI1ftvnhN5nxMKETo/w; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:42866 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l9Z5y-001NmF-BI; Tue, 09 Feb 2021 12:54:46 -0700 From: Tom Tromey To: Zoran Zaric via Gdb-patches Subject: Re: [PATCH 20/30] Add dwarf_entry factory class to expr.c References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-21-Zoran.Zaric@amd.com> X-Attribution: Tom Date: Tue, 09 Feb 2021 12:54:45 -0700 In-Reply-To: <20201207190031.13341-21-Zoran.Zaric@amd.com> (Zoran Zaric via Gdb-patches's message of "Mon, 7 Dec 2020 19:00:21 +0000") Message-ID: <87wnvhauey.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l9Z5y-001NmF-BI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:42866 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: Zoran> This patch introduces a new class in charge of creating, tracking and Zoran> destroying dwarf_entry class based objects. Zoran> +/* Factory class for creation and lifetime management of all DWARF Zoran> + entries found on a DWARF evaluation stack. */ Zoran> + Zoran> +class dwarf_entry_factory Zoran> +{ I wonder why a stateful class is needed for this. Like, why do dwarf entries require reference counting at all? And, in this patch, they are pushed on this vector: Zoran> + /* List of all entries created by the factory. */ Zoran> + std::vector m_dwarf_entries; ... but nothing ever retrieves them, leading me to wonder why it's needed. As with earlier patches, this should probably use a smart pointer rather than passing around bare pointers and doing manual management. Automatically handling this kind of thing is one of the major benefits of C++. Zoran> +dwarf_location * Zoran> +dwarf_entry_factory::entry_to_location (dwarf_entry *entry) Zoran> +{ Zoran> + /* If the given entry is already a location, Zoran> + just send it back to the caller. */ Zoran> + if (auto location = dynamic_cast (entry)) Zoran> + return location; Zoran> + Zoran> + auto value = dynamic_cast (entry); Zoran> + gdb_assert (value != nullptr); Another situation where instead of a type-case, virtual methods are probably preferred. Zoran> +dwarf_value * Zoran> +dwarf_entry_factory::entry_to_value (dwarf_entry *entry, Zoran> + struct type *default_type) Zoran> +{ Here too. Tom