From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YKoaNZH7hmCzagAAWB0awg (envelope-from ) for ; Mon, 26 Apr 2021 13:42:41 -0400 Received: by simark.ca (Postfix, from userid 112) id CBB5D1F11E; Mon, 26 Apr 2021 13:42:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 205C91EE14 for ; Mon, 26 Apr 2021 13:42:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D94AC3951883; Mon, 26 Apr 2021 17:42:40 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.196]) by sourceware.org (Postfix) with ESMTPS id ED8503892451 for ; Mon, 26 Apr 2021 17:42:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ED8503892451 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id A4EE453653 for ; Mon, 26 Apr 2021 12:42:32 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id b5FglRKQHMGeEb5FgljU31; Mon, 26 Apr 2021 12:42:32 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=za58omAA2pzTELLRxoTAVhfQpqCr1LfjJc2T67ODClc=; b=pQz3jxbaElDlg0H/7ko8NU2VhV axXe1rxBMDpA10kbHXeGiCpkYxMMzfY3bBrGqd4MUAJJnTP66v/GGbrEQeVr5ifat4pHMXIqGxqAx UIGJBLA7qHB8n1xaY+9LV2T5o; Received: from 97-122-70-176.hlrn.qwest.net ([97.122.70.176]:46794 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lb5Ff-003OHQ-T1; Mon, 26 Apr 2021 11:42:31 -0600 From: Tom Tromey To: Andrew Burgess Subject: Re: Proposal: format GDB Python files with black References: <20210426162149.GU2610@embecosm.com> X-Attribution: Tom Date: Mon, 26 Apr 2021 11:42:31 -0600 In-Reply-To: <20210426162149.GU2610@embecosm.com> (Andrew Burgess's message of "Mon, 26 Apr 2021 17:21:49 +0100") Message-ID: <87wnspuem0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.176 X-Source-L: No X-Exim-ID: 1lb5Ff-003OHQ-T1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-176.hlrn.qwest.net (murgatroyd) [97.122.70.176]:46794 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: Andrew> Right now, if I make a change I edit a file, git add, git commit, and Andrew> finally, git push. At what point does the auto-formatting take place? Andrew> Do I need to manually run the tool after editing the file? Is it Andrew> done, well, automatically at some point? And if it is done Andrew> automatically, then at what point in the process does this happen, and Andrew> how does this relate to code review? Internally, we do it via the Python 'pre-commit' program. Then if I "git commit" in the repository, the formatter is run. It's easy to run manually as well though. For gdb I think it would relate in the same way that testing is done: you just indicate that you did it. Tom