From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9zI8Gi+yVmPXHRAAWB0awg (envelope-from ) for ; Mon, 24 Oct 2022 11:41:35 -0400 Received: by simark.ca (Postfix, from userid 112) id 5A8401E112; Mon, 24 Oct 2022 11:41:35 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=RJlV/bVM; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E59941E0CB for ; Mon, 24 Oct 2022 11:41:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 00FFF3858012 for ; Mon, 24 Oct 2022 15:41:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00FFF3858012 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666626094; bh=itvf7SXWLbdJfr/ITOjyhV38kgw9DyRr2X+GyJE8YPg=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RJlV/bVMqKKtlmeUUVGeET0duTD0huHMtfoj+AdMPqg+njOQDDxXLuNJA64lAJhFp EMRqAHfVG03577XHi3OaSgEWp9KTaNnBYVF0hskQ33m+ZO6hBjrpjYzSfO+VHvdDSV 6KC6Jau97iXsZm9M1U7GxMyamml1MZomtHqSipq0= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 387D33858439 for ; Mon, 24 Oct 2022 15:41:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 387D33858439 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-50-pKvsV8bENj2j1rre83jAIw-1; Mon, 24 Oct 2022 11:41:10 -0400 X-MC-Unique: pKvsV8bENj2j1rre83jAIw-1 Received: by mail-qk1-f200.google.com with SMTP id bq17-20020a05620a469100b006eeb0bbe02bso9219581qkb.5 for ; Mon, 24 Oct 2022 08:41:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=itvf7SXWLbdJfr/ITOjyhV38kgw9DyRr2X+GyJE8YPg=; b=CgBsz5YV3pFQgq3mJhZiyBkoX1aevV3m9K6Y90PUvEnqdAMglrZ/WEnGTN/J5ynncb bYrX7coIAn0RtVWV9G1WI0EmuCND5naE3FYimnGZNGHhdVxjc2P2b0nQWAnUgg2Rz9Zn 2uIHnJFuQ4nZRg77olOFadwKv6UdkIszid6kJda2/TE+VBXWJMO7C+I7ejK6latriIVp f/nu9I1KFJl6rViAbYsOBs59MYpL9vUXu0Xxburf8uD3+b+0lCkdqKIAmX0K5MmSrvm9 75JHUgczERVCjeahCQwGjMM9PNDxqfW7Ofsuzb1ybNmuwuYSyFToFGQW6NALJGicup7C yQHA== X-Gm-Message-State: ACrzQf0noDJ9gE59i147VUb2vTCOQyIfvF7cO/aUdaELCyCUJl9CBPld ijfh3fKWnfYGDmTMiBOv+vxOVMWRBqK+sp2kX5tvsOsU5kotbWOVu0jXBRYeTLA/gn8HIL+hHUw 6lAesjBK1xnxFQ9nYwGaZhg== X-Received: by 2002:a05:620a:2698:b0:6f5:8236:8e82 with SMTP id c24-20020a05620a269800b006f582368e82mr3637442qkp.100.1666626069533; Mon, 24 Oct 2022 08:41:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM45eSYi1YmaA5PEW2DxWzeMIUweRcw6fKZdnyP8llQLYHDYPO54mrTqaAfHWVNmwBdKG5AKpA== X-Received: by 2002:a05:620a:2698:b0:6f5:8236:8e82 with SMTP id c24-20020a05620a269800b006f582368e82mr3637424qkp.100.1666626069279; Mon, 24 Oct 2022 08:41:09 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id i8-20020a05620a248800b006bb0f9b89cfsm149457qkn.87.2022.10.24.08.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 08:41:08 -0700 (PDT) To: Mike Frysinger Subject: Re: [PATCH 2/5] sim/ppc: fix warnings related to printf format strings In-Reply-To: References: <97bcb87aa4ece94b30b62ec5d1845909dbb933a1.1665578246.git.aburgess@redhat.com> Date: Mon, 24 Oct 2022 16:41:06 +0100 Message-ID: <87wn8p8c19.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Mike Frysinger writes: > On 12 Oct 2022 13:38, Andrew Burgess via Gdb-patches wrote: >> --- a/sim/ppc/igen.c >> +++ b/sim/ppc/igen.c >> @@ -442,7 +442,7 @@ main(int argc, >> code |= generate_with_icache; >> break; >> default: >> - error (NULL, "Expecting -Ggen-icache or -Ggen-icache=\n"); >> + error ("Expecting -Ggen-icache or -Ggen-icache=\n"); > > the file is using inconsistent whitespace now > >> --- a/sim/ppc/ld-cache.c >> +++ b/sim/ppc/ld-cache.c >> @@ -88,13 +88,13 @@ static void >> dump_cache_rule(cache_table* rule, >> int indent) >> { >> - dumpf(indent, "((cache_table*)0x%x\n", rule); >> + dumpf(indent, "((cache_table*)0x%p\n", rule); > > you don't want 0x with %p as %p already includes it > > comes up multiple times in this patch Tsukasa OI already pointed this out: https://sourceware.org/pipermail/gdb-patches/2022-October/192598.html The version I pushed fixed this error. Thanks, Andrew