From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SfhIIJGmCGT8mAgAWB0awg (envelope-from ) for ; Wed, 08 Mar 2023 10:15:29 -0500 Received: by simark.ca (Postfix, from userid 112) id 768381E223; Wed, 8 Mar 2023 10:15:29 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Ll24MQh/; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 305FC1E0D3 for ; Wed, 8 Mar 2023 10:15:29 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 59BB43850852 for ; Wed, 8 Mar 2023 15:15:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 59BB43850852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678288527; bh=/WKgplr777Ubzn/RNk/QVXdjwiV4qjxomFdGbyuAj1w=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Ll24MQh/hQgwcMcFrcTi3kiBciE9+Vz4eFL0oYM8UHtRdnRvvUZx6r/J7rK1sbOam GCZN9vsmY36QOuSS5XQsSIrA4XqFrS1q996GeW0vu9yZBG9wJuBbiQZSP6etW0XHDf 5PvHPQlmE1fl5Z0VE7sqvZGLatuANwSyPvPwlQwo= Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 6FAFF3858289 for ; Wed, 8 Mar 2023 15:15:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FAFF3858289 Received: by mail-il1-x134.google.com with SMTP id t1so6740451iln.8 for ; Wed, 08 Mar 2023 07:15:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678288507; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/WKgplr777Ubzn/RNk/QVXdjwiV4qjxomFdGbyuAj1w=; b=yT1/nUGhgOhsV70BUXq+nDndWIxZsmVrhYbYVKQSyGGVwjL7uwopUZLeFkWoSy9SSm d+jkDN0pafAgD2ZO6IMmEkkp2cqa/Cy5S/CMKpxHzrYhh+Jgbit2wMR7x94PfDkKrGra nStW7als8EWtpy/vuJM8HbjZqLsRX7oq08JcerjMZpn7IqTb6o9Rp1Q6tow5T8jgGCTD tHpJvGBVbQSiSweRdVw4vH/P5rYJ+U9/bkHTWvxCVsFlB9fLzmb9qt6Y8UnfoTPVOQDn RHcxpKNolajCLtqrjynTHliJwbFExwixvAaBcS0LAWelgWPg74Z/m32CCxZ/iD0w0UwH sp/g== X-Gm-Message-State: AO0yUKUq0GdjJ1G0DNQVgO8gtqDDaszwSlRZQnACcha34qbAZj7esE85 Cu4frMEXB1MIo7MslLJjVBZZ2w== X-Google-Smtp-Source: AK7set/3gAe4romWmvZk0RWa13fGrbvyNmZyy/l/Gbh2osFQJxD+iXovU2UnEEirG63OI2PB98KgmA== X-Received: by 2002:a05:6e02:170c:b0:315:8e29:a0ad with SMTP id u12-20020a056e02170c00b003158e29a0admr413920ill.11.1678288507713; Wed, 08 Mar 2023 07:15:07 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id e17-20020a02a511000000b003c4eb5cb22csm4911187jam.134.2023.03.08.07.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 07:15:07 -0800 (PST) To: Ulrich Weigand Cc: "gdb-patches@sourceware.org" , "tromey@adacore.com" , "will_schmidt@vnet.ibm.com" , "tdevries@suse.de" , "cel@us.ibm.com" Subject: Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp References: <71926c391f43cee2051ea0c9b449ec0aecc847ec.camel@us.ibm.com> <87cz5ks7zw.fsf@tromey.com> X-Attribution: Tom Date: Wed, 08 Mar 2023 08:15:06 -0700 In-Reply-To: (Ulrich Weigand's message of "Wed, 8 Mar 2023 13:48:25 +0000") Message-ID: <87wn3rnukl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom Tromey via Gdb-patches Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Ulrich> This looks good to me. The only (cosmetic) nit might be that if Ulrich> the function is installed for both 32-bit and 64-bit tdeps, Ulrich> convention seems to be that the function should be called ppc_... Ulrich> then, not ppc64_... Yep, I'll fix that in the real patch. I think I'll do it internally first so I can run it through the test suite, then send to gdb-patches. thanks, Tom