From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NgrICgxfEWZSxyUAWB0awg (envelope-from ) for ; Sat, 06 Apr 2024 10:41:16 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Zu6fClrV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0AA2A1E0C0; Sat, 6 Apr 2024 10:41:16 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AEEB21E030 for ; Sat, 6 Apr 2024 10:41:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 306EC3858C5F for ; Sat, 6 Apr 2024 14:41:13 +0000 (GMT) Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id C57F13858C41 for ; Sat, 6 Apr 2024 14:40:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C57F13858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C57F13858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712414447; cv=none; b=I+EocUbQI8LogsWXwZHCQA7o1of3U1+4x48E5kKZkAkJZLnZjlEELL025oqVbfs9QXrVcIbNBeViNm9+TWvAc2U1o5PkTDOEljagxiXHQcglV0170v6yYldWGi9KiE5nqeAszVqScFhNadeYUhGvO/BbdolpxFsNlYsAxAMb6CQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712414447; c=relaxed/simple; bh=ymv5JWfDDC1i2lN1zhwv8LqnS1k6Rb/co9+UeeRont0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Nh5LMan62joTDzrz5IiyvkC4xhPP4xZt7K7KpIxdMyHROUVPQ4v44KSjpJx5wxLa55/l+b72iVETEJfcfGJzZCgoRgfF95YtcCDm2QqSSgtL3JG3D8ej5eh4TYQPQ4ceipy8U5aGr6M/TyZUQdsQ5TSRPQKYGEx7kA8oPpuu68M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id sPn3rClXftf2Qt7Dnrh9tV; Sat, 06 Apr 2024 14:40:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id t7DnrG6pq9zHMt7DnrgXbU; Sat, 06 Apr 2024 14:40:43 +0000 X-Authority-Analysis: v=2.4 cv=fo4XZ04f c=1 sm=1 tr=0 ts=66115eeb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=7d_E57ReAAAA:8 a=2pr1cotg0FvKgd8rBugA:9 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7rULNLvbT1Bi7vxULZQlD4Ze+12ygXg6hayyCIIYIx4=; b=Zu6fClrVgqi+93/esoX3G0zOko XojfHvpMuSkM1PQK+OBsIHXVGRsZ6V1tC7dKdVz4kCdTeZfIC5FswLoeU0zhANAD14XDJq5JfQ/Fe Vpx2lQZ6QowSRuy8MR9QOeS8D; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:53596 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rt7Dm-002af7-35; Sat, 06 Apr 2024 08:40:42 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] gdb: ignore -Wregister instead of -Wdeprecated-register References: <20240311160715.90270-1-simon.marchi@efficios.com> <878r2opski.fsf@tromey.com> <0780826d-4649-45e8-b056-dcae2a513bb1@efficios.com> <08ccf2e8-6494-4bb4-bcf3-51bedf24ac24@efficios.com> X-Attribution: Tom Date: Sat, 06 Apr 2024 08:40:42 -0600 In-Reply-To: <08ccf2e8-6494-4bb4-bcf3-51bedf24ac24@efficios.com> (Simon Marchi's message of "Fri, 5 Apr 2024 23:26:53 -0400") Message-ID: <87wmpalfkl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rt7Dm-002af7-35 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (prentzel) [97.122.82.115]:53596 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCkHDQd9uy0bzIfEfQpxYlix74LBHnr33NxZOXksXIBghhKcyGz6KbKwvHF52kr+JWyQHja4FS71BfAZFKC3pU9nvlcyj8MSnjtBPd5zVVyPBUrK5G/t u6rkoBzUuu5gbkMtbrNS9N/vWQXJfHEqxJGBuqQIK0DGtdI3yltjDcca+gGI6trCUhfaj+kGfS0jLOj9A+JmExn4ypmVQNyPPsA= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> In ada-lex.l, we already use `DIAGNOSTIC_IGNORE_DEPRECATED_REGISTER`, Simon> which for Clang translates to ignoring `-Wdeprecated-register` [1]. I think Simon> that was produced when compiling as C++11, but now that we always compile as Simon> C++17, Clang produces a `-Wregister` error [2]. >>> Can we just '#define register' in this file or somewhere nearby? >> We probably can, but ignoring the diagnostic seems safer and less hacky >> to me. Simon> Just stumbled on this. Are you ok with the current patch, or would you Simon> really prefer the #define approach? It's fine if you want to do it. I should really finish my rewrite of this lexer. IMO flex causes more problems than it solves. Tom