From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cNGnAQDH7mdQfCUAWB0awg (envelope-from ) for ; Thu, 03 Apr 2025 13:36:00 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Rgy26fuh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E8EB91E0C3; Thu, 3 Apr 2025 13:35:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 229351E05C for ; Thu, 3 Apr 2025 13:35:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A46053836C1A for ; Thu, 3 Apr 2025 17:35:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A46053836C1A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Rgy26fuh Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 15E53383BCEE for ; Thu, 3 Apr 2025 17:35:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15E53383BCEE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 15E53383BCEE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743701725; cv=none; b=sjVkXmJQQlGcelPsu5gpiPLpGG2gKbyZeGPlSpYTFRHl9CdxrDmzML9B5vhBUSdd3lnQlTyUYOpR3JrunhFLM4JhvjqIT3057yn6ShDCco+nijuNOFQHtKDTocL0AsHbKufFnqR1SR8PhLe4maqhZbW7RgEQu3IB42IrdJ319OQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743701725; c=relaxed/simple; bh=gOO4MDJsAE2/cp6I7aa4OM0XUQnCQSsEWhPTDLHwrmo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ed4DIPS39cbXN1Oi3GRX/0YJ3Zmc9mcTRsBal20qUBCY8HVv0FOyIoeFC5A9wMgA0qSaU7unt/chulQP4NWbPSMkQIRA/TDJEHZ3NGuYhe3U25RpLdbfCEV7rlYoWJ/h5hHF4+C2h08rJE32Vnap2853QNmdAyOgczQ1Fe4XSU8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15E53383BCEE Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id 0IDduswopMETl0OTMuwtIt; Thu, 03 Apr 2025 17:35:24 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 0OTLuahui4PG70OTLuMSlt; Thu, 03 Apr 2025 17:35:23 +0000 X-Authority-Analysis: v=2.4 cv=aZVnnwot c=1 sm=1 tr=0 ts=67eec6db a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=XR8D0OoHHMoA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=FkN7_6Lz5laqlTs9ne8A:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AgzGOsEaOJFwkMvPWJomN0W9BUUir2dmOlXmxcfCfqo=; b=Rgy26fuhzCzTImo7Heu6lvJ4s7 xo1UCsGwLnqEW6UQgeGVx8CHck0RsRVFJ/0A6gGEEbvJ9GlcLeNcmvoOAUXLzib/Z1nsmJ8Juw06p FYcwOtoN1bpswDx9/8seFXl0d; Received: from 97-122-123-18.hlrn.qwest.net ([97.122.123.18]:40020 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1u0OTK-00000003ZO5-0fCa; Thu, 03 Apr 2025 11:35:22 -0600 From: Tom Tromey To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3] gdb, configure: Add disable-formats option for configure In-Reply-To: <20250307115821.1507435-1-guinevere@redhat.com> (Guinevere Larsen's message of "Fri, 7 Mar 2025 08:58:21 -0300") References: <20250307115821.1507435-1-guinevere@redhat.com> X-Attribution: Tom Date: Thu, 03 Apr 2025 11:35:19 -0600 Message-ID: <87wmc1173c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.123.18 X-Source-L: No X-Exim-ID: 1u0OTK-00000003ZO5-0fCa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-123-18.hlrn.qwest.net (bapiya) [97.122.123.18]:40020 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCWu2CHsivbaBN2NdoRrQCCE6q263RXnz6tuCKabsh7Ej0PocIUy5NHIV8Soo2AmiOhCUuKtkPkYDve7g2E+FsmpYUMhpqm1LOnY3lmgBstm2Az8PFS1 5+1HF+pkf3k9eKHuc9ndzo7FKrnLPnrv9e5KAGDlWDtTQxLSIRgWoPN2SoCcvucjUU2zzR5NUOlvinXeSq7ciXh8ZrINtgIepaw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Guinevere" == Guinevere Larsen writes: Guinevere> GDB has support for many binary file formats, some which might be very Guinevere> unlikely to be found in some situations (such as the COFF format in Guinevere> linux). This commit introduces the option for a user to choose which Guinevere> formats GDB will support at build configuration time. Guinevere> +* Configure changes Guinevere> + Guinevere> +enable-binary-file-formats=[FORMAT,...] Guinevere> +enable-binary-file-formats=all Add the leading "--" here? I didn't look to see what other NEWS entries do. Guinevere> +# Object files to be used when building with support for all file formats. Guinevere> +all_binary_format_obs="dbxread.o mipsread.o coffread.o coff-pe-read.o xcoffread.o" I would much rather have this kind of information in the Makefile. I know gdb doesn't always do that right now -- but the current way is kind of bad IMO. We can use GNU make features, so it's not hard to transform a list of formats like "elf xcoff" into a list of variable references like "$(elf_OBJS) $(xcoff_OBJS)" Guinevere> diff --git a/gdb/configure.format b/gdb/configure.format Then we wouldn't need this file, either. Tom