From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OEkCGLdJJ2jJbSUAWB0awg (envelope-from ) for ; Fri, 16 May 2025 10:20:39 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=XagtdGkG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5E0191E10E; Fri, 16 May 2025 10:20:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A8CC61E092 for ; Fri, 16 May 2025 10:20:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3A3A13857830 for ; Fri, 16 May 2025 14:20:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A3A13857830 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=XagtdGkG Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 85C633858417 for ; Fri, 16 May 2025 14:20:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85C633858417 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 85C633858417 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747405205; cv=none; b=R6CctmXD2HoBvi2jv6x0uzXSWjoBYp5jQf1933DMp/WOnjm2h8WaqeYG7AIwI6irGiMwCbtEkzc/iu66CmRpmggmf9J4d0DTFTmkbP3C2OxmBh71JzD6eJY79enN0q9l0u1w1laKTFqN4dMLi9MLjhZnKyIGVD0QOCY+ZqG9laI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747405205; c=relaxed/simple; bh=M3fygyNRJE6TKrX+7t+6k0tcKBBl2rvpLEdHriljrlw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XLCP4M641cDaXnOMtouX3qXN4yXZZM4izkX31UtnJv91ajfWGu5AHSGN4W94+z7ijW2guX5+knoGQYojnz46NjKu5A0CrOC81aWkOhU216B+LlR8AWOL11OUxGMirwSZIEd1RyPy1CzLYkQF2TJk3W22y7gRk5C1YmlAI2sx7vk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85C633858417 Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-3da73998419so6599815ab.0 for ; Fri, 16 May 2025 07:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1747405205; x=1748010005; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+1J01euplyXzlF6W7qWYNT2oB1xFslCL85PwnHcfUoY=; b=XagtdGkGgATcZCOjrlDYuIO3KJuG941IBo7d34tK8QUqGNTr3dkqYUAfpP7iRKlXa8 wVI/GlEUVLkwphs92oW6n18SJOYvYWiipvkxdHOPXdmkCs2ILP8TFqAB7BoTNnEf6Pq1 SEj4X+97tw0vOQsMm/pLsdYpVgqWKxhkebxrgOhDyA0wN/scfi/jNg2m1zvAbNQCjn0G xn101rJssUSwej3KCfrqRB1an2Ui0dTK7Y6Hb3CK9pU4ozebz+PoI34vT8Su0O9acLgV Ag3xJtI0eJAwcctl1biPt+73NQNTta+mBj8C8RIg+wkdxaitauIjsHZlU5MrWWYajMHW GVyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747405205; x=1748010005; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+1J01euplyXzlF6W7qWYNT2oB1xFslCL85PwnHcfUoY=; b=HY0Ahl0e2+Ccm2ZuutERm1EoJke4Znd901Utf8FGvCJsWEM0BjQQBQubdbJ29+G+f7 Z8p299XPOEfRklINQZhnFW+o0XkmNHweQC5r5jICu3Y4jAzmuM7hDjRc0FvF0jPEcfCe zL0qVy9OMJEwZiuWxFs1HTvHkkmonXDHNexHprYBhZ3XkOe601tP9f2SKBSPbHpGDfth xdZwpgwab4o7auvLQkS8iFJUh2T6kyWIIuRyx0b5pI8yj/RBsMOoaa3lviUv7QPz+gxO VoXc+GkKIW1CwKLJHi1IcR2p5j4/kXhx660xPqL1Bm+pq3zjPc3AHjj9km8a30L4E+Bc 8XMA== X-Forwarded-Encrypted: i=1; AJvYcCV0mxv/pU4lNFTGKYmP1yiQUY13Sj1n+wDhLTApvQTBFm/XllvsCs6USj6/ZXIsAgStdmVEd/jy3Q398w==@sourceware.org X-Gm-Message-State: AOJu0YyoUHJO3WL106Gkoid+8VWglvFtW/1Maz3WvOYjytWPG/w2mcIK NybITwCWl9/jDjifnI7ifmoCbDyFmpV/+TRuM5oAGt8cULepUBAoTqjKRgwOnn8aJ6/7pM8x4/h 4jZI= X-Gm-Gg: ASbGncuaCGaTV+Budl9L0++kUCvhVGIsw1vQ+3zAckHuy3fX4tDQ5L5k+ByTV73s1cD D78IvTz9H3V35hl/WJmfXg3Ju4D6XhokmpEQiHwnhPjqXrse7xNkxXD0MGcovvNItCtE0hkV+X0 zAJneacJw1hJvCBHVnMtXvAHzuNBPpYH4RW2w1wXSTU5HQx9UaqWD4HjydIEvt9TJY/G3n4n3sJ 2DtYJDRMHVHTw3ep2wAZeu6Q1lXJYYE9eahRKBMn9Bp3QXeoYAce0xemAsAwFtzvABnobwmyKLQ blJGcr0dw59B3a+T7q6W4cOuvDnqE1mG1oIzwxhQlK7dAunio3d/IMDcoPY+pLGlVsLavgY= X-Google-Smtp-Source: AGHT+IFxnLNSeKZ26BZg9UnLM4ABu94s6nns6FDOhzbc+1tP66UL2ZgBcj0v7Nxf1un+8G7w9oWkUg== X-Received: by 2002:a05:6e02:3286:b0:3da:71c7:5c8c with SMTP id e9e14a558f8ab-3db8433475bmr47093915ab.15.1747405204648; Fri, 16 May 2025 07:20:04 -0700 (PDT) Received: from bapiya (97-118-46-156.hlrn.qwest.net. [97.118.46.156]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4fbcc4b2f45sm410178173.126.2025.05.16.07.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 May 2025 07:20:04 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Allow check-mark to be changed for CLI In-Reply-To: <87zfffnqrj.fsf@redhat.com> (Andrew Burgess's message of "Wed, 14 May 2025 16:41:52 +0100") References: <20250509-emoji-check-mark-v1-0-63b6c52411f3@adacore.com> <20250509-emoji-check-mark-v1-2-63b6c52411f3@adacore.com> <87zfffnqrj.fsf@redhat.com> X-Attribution: Tom Date: Fri, 16 May 2025 08:20:03 -0600 Message-ID: <87wmag63jg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> Tom Tromey writes: >> In keeping with the emojification of gdb, this patch changes the >> default "current" marker to be a check-mark. It adds a knob to allow >> the character to be changed, and, as always, reverts to the old output >> when emojis are disabled. Andrew> I haven't tested this patch just yet (short of time), but I wonder if I Andrew> set the check-mark character to a multi-character string, does that Andrew> corrupt the output? I'm guessing so as I don't think table columns Andrew> auto-adjust. Andrew> So my real question: at a minimum, should the docs mention that the Andrew> STRING should only be a single character. And better yet, can we check Andrew> that the string is only a single character in width somewhere? Yeah, I will update the docs in v2. I don't think there's any way to figure out what the display width of a string might be. At least, not unless gdb adds a dependency on something like libicu. Tom