From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YcALKbWsp2mcaxMAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 22:53:25 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MbVQbntR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A29FD1E08D; Tue, 03 Mar 2026 22:53:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 379D01E08D for ; Tue, 03 Mar 2026 22:53:24 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 935F54BA23C5 for ; Wed, 4 Mar 2026 03:53:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 935F54BA23C5 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MbVQbntR Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [IPv6:2607:f8b0:4864:20::a2a]) by sourceware.org (Postfix) with ESMTPS id 50E464BA2E1D for ; Wed, 4 Mar 2026 03:52:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50E464BA2E1D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50E464BA2E1D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772596377; cv=none; b=A+Seax8Qdq4FBTHgKal9exKJKYpvv8uRpUNa/rDXrnCB8AM9c8qWXhFhVXzIwAbICLcxgDwmNW/E9gNuehJZUPIbAbF9/jwhwhUfDFqGKhI4WmiVkaIxQzQhP7tG5zHI9xgd47Uami9fqBEq5yqBvfgnZaMX3BZ8CNitCSsy/nU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772596377; c=relaxed/simple; bh=d8RzDqhdsssUFerkTi759pD2MLMqjj29aDBmCELFkH0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aeO/TcxvM+0X8eIeUqrIrvOpnM8PaT7ccuiegy+t0LA/9eFhjz3eqJuUc2nRjq6ie+kxTd14pKyS5wwmFyGUsPqU/Eo0wQ68HfOhWmqQQgZ2FMwraQetmYdIBvbkZb3lPMoA0OIsh8fWgW4NapxBhZ0LnokdPwuviH30sXC4Y9c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50E464BA2E1D Received: by mail-vk1-xa2a.google.com with SMTP id 71dfb90a1353d-5673804da95so2795604e0c.0 for ; Tue, 03 Mar 2026 19:52:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772596377; x=1773201177; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q2in2fdP4HeNQ7sHeEc1Kyw4VblGPvBdRKqynjAlwLs=; b=MbVQbntRW5TUMbtJm1E0oYVdqx/jKjjs95+YtLncWI2FDQKxmtY1VALWyoz/J/OcpG 6HEFw1ib/vXbMEGQk9k7M2Xu76gD7IQG/1/146CG+idUCJosnqwUMGjPdfONwSZxLlNM Wb8HREVmj+DF5PD92Y3ONbbpQpjfswcP8IM22h18m0mfFiqy87zQvtuunbpDgGdHRAw0 oDA+/xC1TLKthQQfgZUALk7SlZI40OmyUXI7KsyCbZGtUID69gkW3Y8lxqagus1iprMS uvUlD9p0bleaB+Obx6uCr+7r9o10lmjY1eb0gyvcA6PUVWwofc20YzSUSJsnHyKktMRX 21vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772596377; x=1773201177; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q2in2fdP4HeNQ7sHeEc1Kyw4VblGPvBdRKqynjAlwLs=; b=PtT9BRB6sv+Cig9wrX99szqX/mfHssjeJN5sWgKk5uP1YhoND4N+hjZsQKLp+cuypH tRol/pWtICrJfDi0pZFVwN6VW1fAFJS3gaR14j/rcxgKU3CoHXG9D5DlA7X5My2ID1ld BGPteDJ154K34JJyU0KFoLBAoEabOptT09sSvyrX1qM7i0IoXeGqby+ijuqiNwRJAgkH XysW1kB8WeUMjXth5MG4eH9q0eVVcRFVF8HYNwezFMlLpqIBkjy0fncZrxt8nYKo2v/W PMYGjQCQPFBaPKxni7DTh/Wg9LNOvN5RuWoBKQYRVvXkAoTBCfHiRr70npOD/vmpvtFe HiDQ== X-Gm-Message-State: AOJu0YzZJG6MKl+ZU65R/Zls8MWGSmQALqQBp+ZxC4JrYAycb9wv1PDN CGDBnJ1hdKzwmfOUegqr1XDn9yECwRw/5/JGLx2dq/OE/eQHkgrWrT4GhtdA4ntZJVU= X-Gm-Gg: ATEYQzyBNB4ZsipHhTtQ6yKQlwBLsESIgtWqR6Yl/6ebBPbwZPdq/q01DPqWpH7RHub MZRuwF5gXQeqy2gVoUpcQkkqcjJrtEQaya9JRXbFt62P4kwvhWymmBgeE95WJkV0IR//FmipSeJ 7M8l5gBjlrW0KgXcAiApDeiSuXaWRghFk0DiYvKsaZZ/CrCv3n2yOvAmmhjddflGDGWyoCRNJHY hIf0I6D54kz8buB2azc6U4F/H0auvffSJ8HL09ESchl9MnWUQXwKCVZHftquIRciYJCTXK/5hZX cEJ5fv4gjXQF7EiiBzlmiCyqhhuqWRhHGcJa90a7YU8+GpRev6SLqiNi6OU7GyR4TBU8Ku2iHRp TAUFi7FJCMXUrzuagAlWW4o+I6NWeHdVY8+GXdhkUUtY79osnYOD8r1h9FKP8nY6ubsNfYyD55p d7D5V1UdwZiSmHXSCqVVy3vYaJbGANDKjPAA== X-Received: by 2002:a05:6102:e14:b0:5ff:1d94:b744 with SMTP id ada2fe7eead31-5ffaac2a7b5mr276438137.13.1772596376546; Tue, 03 Mar 2026 19:52:56 -0800 (PST) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-94df61672ddsm17143397241.0.2026.03.03.19.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 19:52:56 -0800 (PST) From: Thiago Jung Bauermann To: Simon Marchi Cc: gdb-patches@sourceware.org, Chris Packham , Luis , Tom Tromey , sunilkumar.dora@windriver.com Subject: Re: [PATCH v4 0/6] GDB: aarch64-linux: Some header fixes In-Reply-To: <643ff55e-b906-40e0-aef9-847b1af9a7c1@simark.ca> (Simon Marchi's message of "Tue, 3 Mar 2026 11:14:08 -0500") References: <20260303050641.198127-1-thiago.bauermann@linaro.org> <643ff55e-b906-40e0-aef9-847b1af9a7c1@simark.ca> User-Agent: mu4e 1.12.15; emacs 30.2 Date: Wed, 04 Mar 2026 00:52:53 -0300 Message-ID: <87wlzscktm.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello Simon, Simon Marchi writes: > On 2026-03-03 00:06, Thiago Jung Bauermann wrote: >> v4 adds two new patches, reorganizing MTE and SME definitions. >>=20 >> With this series, I think the AArch64 definitions are correctly organized >> between the headers in gdb/arch/ and gdb/nat/. >>=20 >> if the series is approved I will propose a version of the last patch for >> the GDB 17 branch which doesn't depend on the previous patches, so that = the >> build failure on aarch64-linux-musl can be fixed with minimal changes. >>=20 >> I didn't include Luis' Approved-by to patches, since they have some chan= ges >> in them. >>=20 >> I also build-tested this version on aarch64-freebsd14.3 in addition to >> aarch64-linux-gnu and aarch64-linux-musl. >>=20 >> Previous versions of the patches: >>=20 >> v1: https://inbox.sourceware.org/gdb-patches/20260211045853.1436881-1-th= iago.bauermann@linaro.org/ >> v2: https://inbox.sourceware.org/gdb-patches/20260214045504.361392-1-thi= ago.bauermann@linaro.org/ >> v3: https://inbox.sourceware.org/gdb-patches/20260217060106.1906312-1-th= iago.bauermann@linaro.org/ > > I skimmed the code and read the commit messages, it looks good to me, > but I will leave Luis give the approval. Thanks for the cleanup, I > think things are organized in a systematic and predictable way now. Thanks! and thank you for the prompt review. > Here are some things that copilot had to say, I checked and they seemed > true: They are true indeed. > - gdb/nat/aarch64-pauth-linux.h: HWCAP_PACA is defined unconditionally, > unlike every other HWCAP fallback in the series (HWCAP2_MTE, > HWCAP2_FPMR, HWCAP2_SME, HWCAP_GCS) which all use #ifndef guards. On > any modern aarch64 Linux system HWCAP_PACA is already defined by > , so including this header after any header that pulls > it in will cause a redefinition error. Wrap it in #ifndef HWCAP_PACA > / #endif. Ah, I missed that. Fixed locally. > (Simon: not sure it will necessarily be a error, I think it's possible= to > redefine macros if they have exactly the same value, but still it > would be good to add the #ifndef.) I tested and you are correct. There's a build error only if the definitions differ. In the process of testing this, I noticed that the #ifndef implies that is included, so I amended the nat/*.h files that define HWCAP macros to also include it explicitly. And also in the case of one header which defines a couple of ptrace constants. I'll detail it in the respective patches. > - FPMR: the commit message appears to be a copy-paste of the pauth one > that wasn't updated =E2=80=94 it references AARCH64_HWCAP2_FPRM, HWCAP= 2_FPRM, > and gdb/arch/aarch64-pauth-linux.h / gdb/nat/aarch64-pauth-linux.h, > when all four should refer to the FPMR variants. Argh. Fixed. > (Simon: notice the FPRM -> FPMR typos in there) Argh again. Fixed again. > - GCS: the commit message says "create > gdb/nat/aarch64-gcs-linux-ptrace.h" but the file actually created is > gdb/nat/aarch64-gcs-linux.h. Yes, I originally called the file ...-ptrace.h but then I changed my mind and forgot to adjust the commit message. Fixed. --=20 Thiago