From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ud+VBEA25mllrSwAWB0awg (envelope-from ) for ; Mon, 20 Apr 2026 10:20:48 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=AsG4Hx+B; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0E7831E0BA; Mon, 20 Apr 2026 10:20:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8C2551E067 for ; Mon, 20 Apr 2026 10:20:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E3CEC4A98F05 for ; Mon, 20 Apr 2026 14:20:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E3CEC4A98F05 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=AsG4Hx+B Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id B574D4D8D1E6 for ; Mon, 20 Apr 2026 14:20:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B574D4D8D1E6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B574D4D8D1E6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::233 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776694821; cv=none; b=BDFkP9caizp3waO9ux4ROVkxYZSgdRYBjFj4py45o0TcDsd2uWeKNhQjNnv8YChGYW3OnDGfYV3AuEn4xjDjurZg02fdxARLApaZXKlNk9sHQzi/eWprJSk7kedO3+r/AS3bF56RISOoniOXBN0lla48kpmp9h+3/XA1pzW0a5E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776694821; c=relaxed/simple; bh=LbSRJRIsVlDkbwjI2au/CVQHtpA6W5ergMdVqk3UC58=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sZguYpomPrAChSi6lXwrPF/I51B3KAGqY4ZE86LY8CPboKX/ySPDTm6sUEMRsHihJiiAC2vXfazND6qRTPg5Rzy7cW0lR0xfprELhVEkDdvyvKez4YZpB6SXrKwg/z113N0E7fxJACcLfj1lW37oNFYqTIZRXJQpKigFchVNnsI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B574D4D8D1E6 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-479932ccb9bso840573b6e.3 for ; Mon, 20 Apr 2026 07:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1776694821; x=1777299621; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=UZ0JIC4l2JMYZkWXhuwW/8HfVStVXCkPwR/hQd0arfw=; b=AsG4Hx+Bu47LZN28XWCrFowhYWNNl9XHnG080yJTD9rbVnf/fr4R4uGwofRWFejaQd 9cT07xTPvNlwr7U7W3kINAgIMZ0nyJJbkiPCzuiDP+keApsOlGiZNv8P+BxT4aWviYXN 1H+eNnhEGi1ua6gdBgCVVJfSQ6sOpVzj2E7kG7iec3YtnfKrwUAXihznTExF9vykZqFk 0AijM4hLfgn8tHgHwhkGHiQg+lDhXz8J4TksmhNWfImn8ZJDQ34xYwcgPkHewF5RpFer Ft1ZaVvKFYEnDaVZ+F9iVWyc53dnXxGBfEFAK2Ao9QM5uYZqh8iKSmSGYJL6eFiOBGGm l14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776694821; x=1777299621; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UZ0JIC4l2JMYZkWXhuwW/8HfVStVXCkPwR/hQd0arfw=; b=IeARmE+5ptfheMaj20/V9Jdo2Gqv6m959nxTX7LtxiPlPzpHiX67p6fuw58TWC5uv8 HUbq7KtV5FQjNo4crf/hmXTAp+KXFOJSMJ4b9/QN9j/T/STUyjvBL59Ad8KIWqJJbE54 a6Pcw8hVKEEpCR8dg99MKlI31mPN1qmURFrOgh1g5ia+/4ZJ4B/Zuz/v3Wwj+Dd9YcmZ C0fWRBqxpc8peJu+7xIAxBNgNKzuCTqFWAMioAb9BiYxljZdzmBeSe8HMoeg0DYA8T82 Iq7NgRqfQEwkckXBPZiV0kL05sMPvVB6xAos2Bmxv5asHNzUc+yerKBOdpX+MHVDctY8 +0fw== X-Forwarded-Encrypted: i=1; AFNElJ8/Oa33j+bgF9heJh3HWURiXDe1E5awCzJuAclNWkV3fB6lYkLZXZFzebjo3HW6N07zziIKXv9zwIC46w==@sourceware.org X-Gm-Message-State: AOJu0Yz1lP5Ge5fPFyi3IBwBq6ozn00Ux8cRso3o7rakReN+h8hL4Avf hXGaf9lVqGsuRdhQnXZygGqv4Yg+6t9EY1ejBiUtcSCESHQuQorVDXzwCZp6zLbXWg== X-Gm-Gg: AeBDies4W85uZ/52SOa6liv0Hpj1UEf+82lvilJqBD72UzQwKIGiq+Kb+q9/jg0RYBz eJCvDAJIpWUK2MHxpgZnYcNx5nMKUL8Rfm0+s7QD8vQV+0dJORIxOII6qGxw2IWCcMDVxJSouwf Heict7Pj/O0umKn7wGRo5PH3ca3RybD7nPJzPBvB6qtku/cofOcobWTFDPi0iNukDJ9X1vcBOXt yTD+8i3N0rEe/ljvlBsx72qtxPi3MxfzGRjx5B14GIy8bk2KtdlJokHzIjvKHS8jDYu5HJwPCm1 HtgeBKdlPZaaXxhKyMvf43qXoKhoawtGZj/n7KVbg6l4YRWdS41j9ZSp9yRsrhbCyUSw1W1CgF5 kwToGe8jzVXqdq23tSjPPG/90S7+od50fGRdWS1uedC1GtrEQPJjuP34+18lp+z71M/WHzTg9cF uhAAM8tEFvJNKja2RK6kn9OhZIC8uhX35BAWIAVx3CpzZgoy0HWhhoqQ== X-Received: by 2002:a05:6808:50ac:b0:46c:e542:cc25 with SMTP id 5614622812f47-4799c8786d8mr8130229b6e.9.1776694820942; Mon, 20 Apr 2026 07:20:20 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dc9759b93dsm8394033a34.14.2026.04.20.07.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:20:20 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] Change pop_context to return a block In-Reply-To: (Simon Marchi's message of "Fri, 17 Apr 2026 16:11:21 -0400") References: <20260417-list-in-scope-v1-0-0deb050fc03d@adacore.com> <20260417-list-in-scope-v1-4-0deb050fc03d@adacore.com> X-Attribution: Tom Date: Mon, 20 Apr 2026 08:20:19 -0600 Message-ID: <87wly1r9wc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >> + context_stack cstk = m_context_stack.back (); Simon> A nit about pre-existing code, but I think that we could std::move the Simon> result of `.back ()`: Simon> context_stack cstk = std::move (m_context_stack.back ()); I did this. Tom