From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Z2mdDvKSiGqmbjQAWB0awg (envelope-from ) for ; Fri, 21 Aug 2026 14:03:30 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oxFFBBNz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 292041E033; Fri, 21 Aug 2026 14:03:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 955101E033 for ; Fri, 21 Aug 2026 14:03:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2598C4BB24C9 for ; Fri, 21 Aug 2026 18:03:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2598C4BB24C9 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oxFFBBNz Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 3EFAF4B9DB4A for ; Fri, 21 Aug 2026 18:03:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3EFAF4B9DB4A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3EFAF4B9DB4A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787335384; cv=none; b=KnbyTt0b1SSJF9ZXHVtAnHdKesPNno09OrvkYVcZWAW1Vge1gL+vzNYTVxTTzNtDzmBIpGxuz2329G7eDovPBAdUs1g2fGPcmXTzRTVh1awhLkSfCA88SvykCs4ZCAqN47wB/1BqRLSc0CDjNqUDIoNMigj+n5e/N0F+DMfKcnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787335384; c=relaxed/simple; bh=Jw2dN03QswEuiRe9HNhaFSHpqZ8P8Xs0XeIS5+pvM9E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IPfomqxYpZTKX6Cb9y6mLlCJLMyfw5jZYoT+sW5m0MVw3ZP8C1LkLy9H5j50BHEsBLCLPq0yDTyiMGKHWAUiMX16+WnPLyLWxrV5tUhsywc2sr+MoWl3T5H507RWIFqa5LAnBi/tOSyqmeF2PiSaRArmII/MIXBQZ0e02j0pyXk= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oxFFBBNz reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EFAF4B9DB4A Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id xMy7wJANpusRSxTa2wIP9T; Fri, 21 Aug 2026 18:03:03 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xTa2wpBqBptIWxTa2wBIk4; Fri, 21 Aug 2026 18:03:02 +0000 X-Authority-Analysis: v=2.4 cv=TsHmhCXh c=1 sm=1 tr=0 ts=6a8892d6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=jxOBdIovUuweWiZT7IQA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7YnFaYO4lxUWe0e6fTcBKPiyqqcUcLDERE4L2LVyfcg=; b=oxFFBBNz1BwovMdUEvRKzIWznZ lSFo5Bt6zDtF1+pCAPvviZMfa7p6rsjAGiAp/TYHN9elgUB4YZ5szMlUOLtTrNBhR7SwWRdUlGNA5 6FBZL6DDH4ZjHoOFlOtoyKRHn; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:36102 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wxTa1-00000002MzB-3Adz; Fri, 21 Aug 2026 12:03:01 -0600 From: Tom Tromey To: Hannes Domani Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/8] Windows gdb: Use allocated buffer for CONTEXT In-Reply-To: <20260727174619.1089041-2-ssbssa@yahoo.de> (Hannes Domani's message of "Mon, 27 Jul 2026 19:42:26 +0200") References: <20260727174619.1089041-1-ssbssa@yahoo.de> <20260727174619.1089041-2-ssbssa@yahoo.de> X-Attribution: Tom Date: Fri, 21 Aug 2026 12:03:00 -0600 Message-ID: <87wltjpd0r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wxTa1-00000002MzB-3Adz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:36102 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNmcJ+6J+LtRSB95q2PBt13wtKf/yka8VXN+jTGlzxRwHPrTUw5cfdDunSJxCiWGfjnNmyqudb4PoM/h4r0QmLUXQ2u69iaOyfpuOTJ3ViD/c2/L7haK 6dMxTUreGXqze4HoDaewL9bGF1mXwDR2KWokHEKH9ViYyJbJr5yCmGG2+S61UfVe3vfguAYXutMupHxaO2Xn4x+esN5hk4HOEd0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Hannes" == Hannes Domani writes: Hannes> This is done in preparation for the XState functions, because the Hannes> extended registers are stored directly after the CONTEXT, and its actual Hannes> size depends on the available XState features. Minor question about this one. Hannes> +/* See windows-nat.h. */ Hannes> + Hannes> +void windows_process_info::initialize_context (windows_thread_info *th) Hannes> +{ First a nit, newline after 'void' here. But also I wonder why this initialization isn't simply done in the constructor? Looking at the calls: Hannes> windows_private_thread_info *th Hannes> = new windows_private_thread_info (windows_process, ptid.lwp (), h, base); Hannes> + windows_process->initialize_context (th); Hannes> th = new windows_thread_info (&windows_process, tid, h, base); Hannes> + windows_process.initialize_context (th); ... they both come immediately after construction. Tom