From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SQxOHOzY2Gq40QQAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 11:23:24 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oPmftF70; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5D0D91E051; Wed, 21 Oct 2026 11:23:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C5FC71E04D for ; Wed, 21 Oct 2026 11:23:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 07F844BA79B0 for ; Wed, 21 Oct 2026 15:23:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07F844BA79B0 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oPmftF70 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 8A9AB4BA798B for ; Wed, 21 Oct 2026 15:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A9AB4BA798B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8A9AB4BA798B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792596109; cv=none; b=ArXtEkhnzrVGOJPGnr7W/5aZVPtVsE+zR0EXbm12Wgl6C+BCZwoZzUWFwmHem21MJ4SbWwizdyPuGlhYa7+tD1FRlHjMfMNYaq63MiZAA2UH7y2dQHm1IupFAnhnBeUe5hNGJpx+xJ8Ot0XFfr2LbHv1oi6uVtE/LmuLcokvO2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792596109; c=relaxed/simple; bh=0/YumMHmI4aVCE2D4xccxnRxJkISCzWnQN1ZfcJu9vw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jRwJ0IFlG3FJuQyxVnsRJ94l4NJsCh1KBSUEr5v9byC09CXw+T8XTdksCKb4MCBrdb1XjrBKrjVGyhrODy0RAxGqQ6/lASdCjvbK8gRWlHSDzOuvXRBuOu2VTgNB0tAuLcyT2qEkagbVE4ueI2pIEWv53S5JGeeI6aB/Ij35TzI= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oPmftF70 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A9AB4BA798B Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id JEojxTallv0ndJY8RxXP9L; Wed, 21 Oct 2026 15:21:48 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JY8Qx6H8TFB8dJY8RxAPoh; Wed, 21 Oct 2026 15:21:47 +0000 X-Authority-Analysis: v=2.4 cv=HcoUTjE8 c=1 sm=1 tr=0 ts=6ad8d88b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=sfe8giY-CosydHhCveYA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qMt3IAUrB1vMyr044n/gT3tsPo2DudHOSHW86DzKpe4=; b=oPmftF70UTZt0TbMybOFHhAJdS Dkj/nmcwEOOpzetcojiWTEVymtDJpMB8gwMbgecS6bPworPntvY2vuwtYof8IM4AKPMq66F7Mnj0z jDCZR8PoTIBRkko3wIkPhQ6wn; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:38780 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJY8Q-00000001Vsj-2WEs; Wed, 21 Oct 2026 09:21:46 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/13] gdb: check exact results in the canonicalize selftest In-Reply-To: <20261020162054.2140671-7-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 20 Oct 2026 12:17:28 -0400") References: <20261020162054.2140671-1-simon.marchi@efficios.com> <20261020162054.2140671-7-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 21 Oct 2026 09:21:45 -0600 Message-ID: <87wlrbyt86.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJY8Q-00000001Vsj-2WEs X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:38780 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDrndGSzyj0SIqIDbHrLTLuPAToc0T/WZBQACdnWeiH32jQEi4RZpXRicwPmEhwDHhTm1I4eZqGY0n31mBwLR8ka6/2iEcBH31NnVge7T75q5JpfTvhp 40UzRznFegS/vNBBIuPIZClwVJ57r0BaABLSgoAABt72/231kW9xgOGFnvjilCcEeNwMstFKryO0gcUUmjx9fPda//T45as0OPU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> The canonicalize selftest uses should_be_the_same, which canonicalizes Simon> two names and checks that the results are equal. This doesn't check Simon> what the canonical form actually is: both names going through the same Simon> wrong conversion would still pass. I think the idea here is that gdb shouldn't actually care which form is the canonical one. So I'm wondering if there's some reason you think it should? Maybe some kind of comment explaining that the rest of gdb ought not care would be sufficient. As in, if some future developer needs to change the canonicalizer to return something else for some reason, they'd be free to. Tom