From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-89970-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4284 invoked by alias); 17 Apr 2012 17:34:32 -0000
Received: (qmail 4187 invoked by uid 22791); 17 Apr 2012 17:34:31 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 17:33:39 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3HHXccG003607	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 17 Apr 2012 13:33:38 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3HHXbxg021476	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 17 Apr 2012 13:33:38 -0400
From: Tom Tromey <tromey@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)
References: <CAGyQ6gyuJ1oYBH3O5gzNc7Y7NK7AGC2F9a8Z3ts4dMm0GpVy0g@mail.gmail.com>
Date: Tue, 17 Apr 2012 17:37:00 -0000
In-Reply-To: <CAGyQ6gyuJ1oYBH3O5gzNc7Y7NK7AGC2F9a8Z3ts4dMm0GpVy0g@mail.gmail.com>	(Siva Chandra's message of "Tue, 17 Apr 2012 12:55:43 +0530")
Message-ID: <87vckytg9a.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00505.txt.bz2

>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:

Siva> The attached patch is a result of discussions here:
Siva>     http://sourceware.org/ml/gdb-patches/2012-04/msg00226.html
Siva> and here:
Siva>     http://sourceware.org/ml/gdb-patches/2012-04/msg00302.html

Thanks.

It looks pretty good, just a little nit.

Siva> +  block = symtab->blockvector->block[GLOBAL_BLOCK];

Siva> +  block = symtab->blockvector->block[STATIC_BLOCK];

These two spots should use the BLOCKVECTOR accessor macro.

Ok with that change.

Tom