From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5701 invoked by alias); 26 Apr 2012 18:59:48 -0000 Received: (qmail 5691 invoked by uid 22791); 26 Apr 2012 18:59:47 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 18:59:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QIxQPC027318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Apr 2012 14:59:26 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QIxPqm032516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 26 Apr 2012 14:59:26 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [3/10] introduce psymtab users References: <87haw7brks.fsf@fleche.redhat.com> <20120426172711.GA19350@host2.jankratochvil.net> <87zk9y72zv.fsf@fleche.redhat.com> <20120426184219.GB21029@host2.jankratochvil.net> Date: Thu, 26 Apr 2012 19:04:00 -0000 In-Reply-To: <20120426184219.GB21029@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 26 Apr 2012 20:42:19 +0200") Message-ID: <87vckm720i.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00954.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> If PST is not yet expanded it means very every pst->users[i] Jan> element is also not expanded, right? That's right. When expanding a PU, we look for a canonical including CU, and expand that instead. This is handled by the loop in psymtab_to_symtab. When expanding a CU, we expand all of the PUs it includes (but in isolation, we don't go "back up the chain" to the canonical CU). This is handled by how the symtab reader processes DW_TAG_imported_unit. Tom