From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30308 invoked by alias); 17 May 2012 15:27:47 -0000 Received: (qmail 30298 invoked by uid 22791); 17 May 2012 15:27:46 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 May 2012 15:27:25 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4HFRKAl011082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 May 2012 11:27:20 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4HFRHmA028245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 17 May 2012 11:27:18 -0400 From: Tom Tromey To: =?utf-8?B?QW5kcsOpIFDDtm5pdHo=?= Cc: xgsa , "gdb-patches\@sourceware.org" , Vladimir_Prus@mentor.com Subject: Re: [patch] Use the string returned by pretty printer for MI varobjs instead of "{...}" References: <305151335125397@web28e.yandex.ru> <87likttnme.fsf@fleche.redhat.com> <20120516010500.GB3321@klara.mpi.htwm.de> <87zk98qijh.fsf@fleche.redhat.com> <20120517121923.GB6350@klara.mpi.htwm.de> Date: Thu, 17 May 2012 15:27:00 -0000 In-Reply-To: <20120517121923.GB6350@klara.mpi.htwm.de> (=?utf-8?Q?=22Andr?= =?utf-8?Q?=C3=A9_P=C3=B6nitz=22's?= message of "Thu, 17 May 2012 14:19:23 +0200") Message-ID: <87vcjultey.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00656.txt.bz2 >>>>> "Andr=C3=A9" =3D=3D Andr=C3=A9 P=C3=B6nitz writes: Andr=C3=A9> 'git blame' thinks you added it in September 2009, so gdb 7.0 is Andr=C3=A9> probably the first one that has it. Calling code "broken" just Andr=C3=A9> because it handles (also...) "legacy" setups is a bit of a stre= tch Andr=C3=A9> in my opinion. We're only talking about dynamic varobjs here, which the MI user must explicitly request. Checking a dynamic varobj for "{...}" has always been wrong, since they were first introduced. Looking at this for non-dynamic varobjs... well, I wouldn't do that, but it isn't relevant. Andr=C3=A9> If you really want to read more into the comment than what was Andr=C3=A9> actually written, then perhaps a friendly nudge to adapt the Andr=C3=A9> documentation to existing practice. As far as I know the documentation is correct. Tom