From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20716 invoked by alias); 4 Jun 2012 20:47:12 -0000 Received: (qmail 20707 invoked by uid 22791); 4 Jun 2012 20:47:11 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_STOCKGEN,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jun 2012 20:46:58 +0000 Received: by pbbrp2 with SMTP id rp2so6805080pbb.0 for ; Mon, 04 Jun 2012 13:46:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:message-id:from:to:subject:x-gm-message-state; bh=xpRvW1FutR2PTvUzn9C59tcl85u/68uzow2xyOOyoOE=; b=aCxcTZ8fsWniyWhGzzCbzNHP/CimVfK9eIlsKWD53w+HReaaUHRED1atHJqXNYdnKy YXROv1yCCJxIDAZbDOAzGN3rCmZsMXXN7m2lUYOTxJWnnIzCqhjtJS6sfUnUbrQFWENg KZ0M8B8QMXVYSKgGmBHSwOv1kl8YJ4nb/iqRTBTakBMoerqvdozNyVt1GXHv8pvmkSLx tXXuReft0/aV2mdrKzmxk7aVG9K7Fp2xtvv9jBdHlbQ8XTY/7xaq+BqP9rmZtim4K1bT CM5COuC3F0xmjosfx1xuHD4709ir0yG3933pGs0/aQAjGuLSCCEffWbcuDtP70/UJJnw nYfw== Received: by 10.68.232.201 with SMTP id tq9mr43861074pbc.70.1338842818029; Mon, 04 Jun 2012 13:46:58 -0700 (PDT) Received: from garudatw.twitter.com ([8.25.195.26]) by mx.google.com with ESMTPS id ts3sm14417172pbc.7.2012.06.04.13.46.56 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Jun 2012 13:46:57 -0700 (PDT) Date: Mon, 04 Jun 2012 20:47:00 -0000 Message-Id: <87vcj624dl.fsf@garudatw.twitter.com> From: Kaushik Srenevasan To: gdb-patches@sourceware.org Subject: Fix GDB crash while trying to display the return type of a JIT frame. X-Gm-Message-State: ALoCoQk/hXQQ1oTPVUtMPY9msbLO379D9PDP/l8H+pFOuOz5fzEXt7pvR92rlOu/ZwZR1z0YhCu2 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00100.txt.bz2 This patch fixes GDB crashes due to missing function return type on JIT reader symbols. See http://sourceware.org/ml/gdb/2012-05/msg00126.html for the original discussion. -Kaushik 2012-06-04 Kaushik Srenevasan * jit.c (finalize_symtab): Set function's return type to 'void' by default. diff --git a/gdb/jit.c b/gdb/jit.c index f172e41..7bd4a27 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -672,6 +672,7 @@ finalize_symtab (struct gdb_symtab *stab, struct objfile *objfile) SYMBOL_DOMAIN (block_name) = VAR_DOMAIN; SYMBOL_CLASS (block_name) = LOC_BLOCK; SYMBOL_SYMTAB (block_name) = symtab; + SYMBOL_TYPE (block_name) = lookup_function_type(arch_type(target_gdbarch, TYPE_CODE_VOID, 1, "void")); SYMBOL_BLOCK_VALUE (block_name) = new_block; block_name->ginfo.name = obsavestring (gdb_block_iter->name,