From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16906 invoked by alias); 16 Nov 2012 19:32:41 -0000 Received: (qmail 16897 invoked by uid 22791); 16 Nov 2012 19:32:41 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Nov 2012 19:32:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAGJWWCV004931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 16 Nov 2012 14:32:33 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAGJWVc7022663 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 16 Nov 2012 14:32:32 -0500 From: Tom Tromey To: Cc: Subject: Re: [PATCH] Python 3 support, part 2 (testsuite part) References: Date: Fri, 16 Nov 2012 19:32:00 -0000 In-Reply-To: (Paul Koning's message of "Mon, 12 Nov 2012 16:10:46 +0000") Message-ID: <87vcd5tkc0.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00472.txt.bz2 >>>>> "Paul" == writes: Paul> Most of the changes are for turning "print" from a statement into Paul> a function call. There are also some changes to handle the fact Paul> that "str" is now Unicode and the separate "unicode" type is gone, Paul> similarly "int" is now long integer and "long" is gone. In the future, please split up patches like this. The patch in its present form is difficult to read. For example, all the "print" changes are obvious -- as a separate patch those could get a simple "ok" without much fuss. Paul> Ok to commit? Yes, thanks. Tom