From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99692-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9616 invoked by alias); 20 Mar 2013 17:37:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9574 invoked by uid 89); 20 Mar 2013 17:37:43 -0000
X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 20 Mar 2013 17:37:41 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2KHbacN012171	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 20 Mar 2013 13:37:36 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2KHbYlY018747	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 20 Mar 2013 13:37:35 -0400
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Yao Qi <yao@codesourcery.com>, dje@google.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Don't use unportable macros
References: <83ip4s4ixc.fsf@gnu.org>	<1363407692-18959-1-git-send-email-yao@codesourcery.com>	<1363407692-18959-4-git-send-email-yao@codesourcery.com>	<CADPb22RwSq0iv_gQu5PSGezQoUy0ve16M2hmL51HvM19v0M5Ow@mail.gmail.com>	<51492077.30307@codesourcery.com> <83sj3qyogk.fsf@gnu.org>
Date: Wed, 20 Mar 2013 17:40:00 -0000
In-Reply-To: <83sj3qyogk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Mar	2013 19:23:55 +0200")
Message-ID: <87vc8m7z1d.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-03/txt/msg00757.txt.bz2

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Wed, 20 Mar 2013 10:35:35 +0800
>> From: Yao Qi <yao@codesourcery.com>
>> CC: gdb-patches <gdb-patches@sourceware.org>, Eli Zaretskii <eliz@gnu.org>
>> 
>> Also define a macro 'mkdir' in this patch, as Eli suggested before.  Is
>> it OK?

Eli> The macro is OK, but please make sure unistd.h is included by this
Eli> file, because that's where MinGW defines the prototype of _mkdir.

defs.h includes unistd.h.

Tom