Re: [PATCH] Fix up msymbol type of dll trampoline to mst_solib_trampoline

Yao Qi
2013-07-18T02:09:42Z

On 07/11/2013 12:56 AM, Tom Tromey wrote:
> This should use ALL_OBJFILE_MSYMBOLS.
>
> I'm mildly concerned that this exposes an implementation detail of the
> minsym storage -- namely, it assumes that it is ok to modify a minsym
> after the minsym is installed.
>

Right, we had this assumption in this patch. If MSYMBOL_TYPE is used in
the computation of hash key, we can't do this after minsym is installed
(hashtab is set up).

> This approach would also block constification of the minsym API.
>
> Neither of these seem like blocking considerations though. Presumably
> bugs arising from the first would be caught in testing; and for the
> second, casting away const would be obviously ok.
>
> So, ok with the ALL_OBJFILE_MSYMBOLS change.

Thanks for the review. Change to use ALL_OBJFILE_MSYMBOLS and
regression tested again. The fail is still fixed.

-FAIL: gdb.base/solib-symbol.exp: foo in libmd
+PASS: gdb.base/solib-symbol.exp: foo in libmd

Committed.

--
Yao (é½å°§)