From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 393 invoked by alias); 1 Aug 2013 17:50:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 384 invoked by uid 89); 1 Aug 2013 17:50:02 -0000 X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 17:50:02 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r71HnrgM005614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 1 Aug 2013 13:49:53 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r71Hnq6X022342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 1 Aug 2013 13:49:52 -0400 From: Tom Tromey To: lgustavo@codesourcery.com Cc: "'gdb-patches\@sourceware.org'" , Pedro Alves Subject: Re: [PATCH] Refactor common/target-common into meaningful bits References: <51FA9649.5060008@codesourcery.com> Date: Thu, 01 Aug 2013 17:50:00 -0000 In-Reply-To: <51FA9649.5060008@codesourcery.com> (Luis Machado's message of "Thu, 01 Aug 2013 14:09:29 -0300") Message-ID: <87vc3pfghs.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00041.txt.bz2 >>>>> "Luis" == Luis Machado writes: Luis> First, it seems like a good idea to stablish a more meaningful Luis> directory structure as well, so we are moving target-common.[c|h] from Luis> the "common" dir to the new "target" dir. This new directory will hold Luis> anything more backend-related. For now it contains only generic target Luis> definitions and functions. I like it. Luis> I've broken target-common.[c|h] into the following: Luis> - target-resume.h: Definition for resume_kind. Luis> - target-waitstatus.[c|h]: Definitions and code for anything related Luis> to waitstatus. Luis> - target-wait.h: A tiny bit that does not seem to fit properly in the Luis> waitstatus files, so it is left here. If I may be permitted to bikeshed just a bit longer... Right now the file is named "target/target-waitstatus.h" and the code says: +#include "target-waitstatus.h" I wonder whether you considered naming the file "target/waitstatus.h" and having the code say: +#include "target/waitstatus.h" That is, let the directory provide the namespace service for us. Tom