From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19177 invoked by alias); 5 Nov 2013 17:23:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19127 invoked by uid 89); 5 Nov 2013 17:23:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2013 17:23:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA5HNQZN004105 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Nov 2013 12:23:26 -0500 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA5HNO9E011649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 5 Nov 2013 12:23:25 -0500 From: Tom Tromey To: Will Newton Cc: "gdb-patches\@sourceware.org" , Patch Tracking Subject: Re: [PATCH] gdb/dwarf2read.c: Sanity check DW_AT_sibling values. References: <52741B5A.6090800@linaro.org> <8761s8w46p.fsf@fleche.redhat.com> Date: Tue, 05 Nov 2013 17:23:00 -0000 In-Reply-To: (Will Newton's message of "Tue, 5 Nov 2013 09:15:31 +0000") Message-ID: <87vc06rcdv.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00076.txt.bz2 >>>>> "Will" == Will Newton writes: Tom> I wonder whether the check should be "<=". Will> I'm not sure. It looks to me that info_ptr at this point will point to Will> the next attribute/DIE which could be a valid sibling? Yeah, you're right. Thanks. Tom