Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] PR mi/15806: Fix quoting of async events
Date: Fri, 16 May 2014 20:17:00 -0000	[thread overview]
Message-ID: <87vbt532co.fsf@fleche.redhat.com> (raw)
In-Reply-To: <53766D85.3070402@ericsson.com> (Simon Marchi's message of "Fri,	16 May 2014 15:56:53 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> As you suggested, quoter == -1 could have a special meaning to modify
Simon> the behavior of printchar. However, I think we are mixing two things
Simon> that are not related. Why should the fact that I want to escape the "
Simon> character influence whether I want to escape \ ? And vice-versa.

I think it's just the normal quoting protocol.  It's odd to quote one
character but not also quote the quoting character.

Simon> They seem quite independent to me. And if there are independent,
Simon> it could mean we need two separate parameters, one saying if we
Simon> want to escape a quoting character and another saying if we want
Simon> to escape the backslashes. WDYT?

Another option is to pass '\\' as QUOTER from remote.c.

It occurs to me now that the patch should probably update the comment
before printchar to document the special meaning of QUOTER==0.

Tom


      reply	other threads:[~2014-05-16 20:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-27  3:08 Simon Marchi
2014-04-28 18:36 ` Marc Khouzam
2014-05-12 17:56 ` Simon Marchi
2014-05-16 15:42 ` Tom Tromey
2014-05-16 17:58   ` Simon Marchi
2014-05-16 18:24     ` Tom Tromey
2014-05-16 19:57       ` Simon Marchi
2014-05-16 20:17         ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbt532co.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox