From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8476 invoked by alias); 19 May 2014 18:21:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8459 invoked by uid 89); 19 May 2014 18:21:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 May 2014 18:21:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4JILSr9008135 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 May 2014 14:21:28 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4JILRhc030019 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 19 May 2014 14:21:27 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v5 1/8] Move utility functions to common/ References: <20140319223004.14668.20989.stgit@host1.jankratochvil.net> <20140319223014.14668.89536.stgit@host1.jankratochvil.net> Date: Mon, 19 May 2014 18:21:00 -0000 In-Reply-To: <20140319223014.14668.89536.stgit@host1.jankratochvil.net> (Jan Kratochvil's message of "Wed, 19 Mar 2014 23:30:14 +0100") Message-ID: <87vbt1y6hk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00363.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> some parts of the former patch have been reimplemented in the meantime by Jan> other patches so this is only a part of the former cleanup. Jan> 2014-02-26 Aleksandar Ristovski Move utility functions to common/. Jan> * cli/cli-utils.c (skip_spaces, skip_spaces_const): Move defs to Jan> common/common-utils.c. Jan> * cli/cli-utils.h (skip_spaces, skip_spaces_const): Move decls to Jan> common/common-utils.h. Jan> * common/common-utils.c (host-defs.h, ctype.h): Include. Jan> (HIGH_BYTE_POSN, is_digit_in_base, digit_to_int, strtoulst): Move Jan> from utils.c. Jan> (skip_spaces, skip_spaces_const): Move from cli/cli-utils.c. Jan> * common/host-defs.h (TARGET_CHAR_BIT, HOST_CHAR_BIT): Moved from Jan> defs.h. Jan> * common/common-utils.h (strtoulst): Move decl from utils.h. Jan> (hex2bin, bin2hex): Move decls from remote.h. Jan> (skip_spaces, skip_spaces_const): Move decls from cli/cli-utils.h. Jan> * defs.h (TARGET_CHAR_BIT, HOST_CHAR_BIT): Move to Jan> common/common-utils.h Jan> * utils.c (HIGH_BYTE_POSN, is_digit_in_base, digit_to_int) Jan> (strtoulst): Move to common/common-utils.c. Jan> * utils.h (strtoulst): Moved decl to common/common-utils.h. This is ok. Tom