From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31807 invoked by alias); 17 Jul 2014 16:49:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31791 invoked by uid 89); 17 Jul 2014 16:49:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 17 Jul 2014 16:49:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6HGnkOw017538 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 17 Jul 2014 12:49:47 -0400 Received: from barimba (ovpn-113-27.phx2.redhat.com [10.3.113.27]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6HGni6Y007995 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 17 Jul 2014 12:49:45 -0400 From: Tom Tromey To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 12/15] Add target/symbol.h, update users References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-13-git-send-email-gbenson@redhat.com> <87bnsxdrtj.fsf@fleche.redhat.com> <20140716102346.GC22380@blade.nx> Date: Thu, 17 Jul 2014 16:50:00 -0000 In-Reply-To: <20140716102346.GC22380@blade.nx> (Gary Benson's message of "Wed, 16 Jul 2014 11:23:46 +0100") Message-ID: <87vbqwvsk7.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-07/txt/msg00479.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> Note that I changed the final parameter to struct objfile *objfile and Gary> added a forward declaration which is never filled out in gdbserver and Gary> added an assertion that objfile == NULL in gdbserver. I don't know Gary> whether you will agree with this but I'll change it back if you prefer. It seems fine to me. Tom