Re: ping: [testsuite patch] for: [PATCH] [PR corefiles/17808] i386: Fix internal error when prstatus in core file is too big

Yao Qi
2015-07-16T14:15:16Z

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> I think the comments above are useful to understand why it does not behave as
> sanely as one would expect (=the real world case for loading kdump i386 kernel
> core files).
>
> So to add another part of the comment?
> # The output therefore does not matter much, just we should not get
> # GDB internal error.

It looks good to me.

>
> Although this whole feature is becoming marginal as i386 kernels in enterprise
> usage (=kdump) have AFAIK mostly disappeared.
>
>
>> > -gdb_test "core-file ${corefile}" "\r\nwarning: Unexpected size of
>> > section `\\.reg/6901' in core file\\.\r\n.*Core was generated by
>> > \[^\r\n\]*'\\.\r\nProgram terminated with signal SIGSEGV,
>> > Segmentation fault\\.\r\n.*" "core-file"
>> > +gdb_test "core-file ${corefile}" ".*" "core-file"
>>
>> >
>> > gdb_test "x/i $address" "\r\n\[ \t\]*$address:\[ \t\]*hlt\[
>> > \t\]*" ".text is readable"
>>
>> We also need comment here to explain the purpose this "x/i $address" test.
>
> Such a comment?
> # Test readability of a core file segment memory.

Sorry, I should be more clear. Let me ask in another way, why do we
need "x/i $address" test? Without the patch fixing PR 17808, GDB should
crash on loading core-file, and we tested that. Why do we do this test
and test whether ".text" is readable or not?

--
Yao (齐尧)