From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24262 invoked by alias); 17 Feb 2015 01:58:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23544 invoked by uid 89); 17 Feb 2015 01:58:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Feb 2015 01:58:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1H1wn7X017954 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Feb 2015 20:58:49 -0500 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1H1wmRo025708 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 16 Feb 2015 20:58:49 -0500 From: Sergio Durigan Junior To: "Jose E. Marchesi" Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH V4 7/9] Simple testsuite for DTrace USDT probes. References: <1422874968-382-1-git-send-email-jose.marchesi@oracle.com> <1422874968-382-8-git-send-email-jose.marchesi@oracle.com> <87fva5718n.fsf@redhat.com> X-URL: http://blog.sergiodj.net Date: Tue, 17 Feb 2015 01:58:00 -0000 In-Reply-To: <87fva5718n.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 16 Feb 2015 20:52:56 -0500") Message-ID: <87vbj15mef.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00382.txt.bz2 On Monday, February 16 2015, I wrote: > On Monday, February 02 2015, Jose E. Marchesi wrote: > >> This patch adds some simple tests testing the support for DTrace USDT >> probes. The testsuite will be skipped as unsupported in case the user >> does not have DTrace installed on her system. The tests included in the >> test suite test breakpointing on DTrace probes, enabling and disabling >> probes, printing of probe arguments of several types and also >> breakpointing on several probes with the same name. > > Thanks again for this awesome testcase. I don't have any more comments > to make about the patch itself; I personally liked your way of solving > the transform problem, though I have a preference to see those changes > in a different patch (i.e., not in the DTrace series). Do you think you > can do that? It should be really easy to extract this part from your > patch; and then, you'd only have to worry about the dtrace-side of it. > > I can't give you an approval for the transform.m4 thing, but for the > rest, you have an OK. I forgot to add Pedro in the loop. Pedro, do you have any comments about this? Thanks, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/