From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59918 invoked by alias); 26 Feb 2015 09:02:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59902 invoked by uid 89); 26 Feb 2015 09:02:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: sasl.smtp.pobox.com Received: from pb-sasl1.int.icgroup.com (HELO sasl.smtp.pobox.com) (208.72.237.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Feb 2015 09:02:46 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id D78CA304E0; Thu, 26 Feb 2015 04:02:44 -0500 (EST) Received: from pb-sasl1.int.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id CD062304DF; Thu, 26 Feb 2015 04:02:44 -0500 (EST) Received: from rusty (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 29F01304DE; Thu, 26 Feb 2015 04:02:43 -0500 (EST) From: Andy Wingo To: Yao Qi Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com, sanjoyd@sourceware.org Subject: Re: Missing test cases for jit-reader interface References: <87oaolx6xy.fsf@igalia.com> <87k2z8ydq4.fsf@igalia.com> <86y4nmvvme.fsf@gmail.com> <87egpeufib.fsf@igalia.com> <54EE4EFD.3060406@gmail.com> Date: Thu, 26 Feb 2015 09:02:00 -0000 In-Reply-To: <54EE4EFD.3060406@gmail.com> (Yao Qi's message of "Wed, 25 Feb 2015 22:38:53 +0000") Message-ID: <87vbipt58v.fsf@igalia.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 39F431CA-BD96-11E4-98CC-8FDD009B7A5A-02397024!pb-sasl1.pobox.com X-SW-Source: 2015-02/txt/msg00740.txt.bz2 On Wed 25 Feb 2015 23:38, Yao Qi writes: >>>> >> +if { ![isnative] } { >>>> >> + return -1 >>>> >> +} >>> > >>> > and remove it too. >> Does it not need to be this way? If you are debugging from a big-endian >> host, you will read the addresses wrong from the inferior, as the >> jit-reader .so reads the values directly. (Seems to me anyway.) >> > > My understanding is that jitreader accesses inferior through GDB, no? Yes, but it does so through a straw, so to speak -- the only interface it has is "read these bytes of memory", nothing about pointer sizes, endianness, etc. And as an exception, the symfile itself is pre-copied into the address space of the .so, but without any kind of conversion. Andy