From: Andreas Schwab <schwab@linux-m68k.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] Fix wrong assertions
Date: Sat, 09 May 2015 18:57:00 -0000 [thread overview]
Message-ID: <87vbg1eg08.fsf@igel.home> (raw)
Both callers and callees are lengths, and the sum of them can validly
equal the total length.
Andreas.
PR symtab/18392
* dwarf2-frame-tailcall.c (pretended_chain_levels): Correct
assertion.
* dwarf2loc.c (chain_candidate): Likewise.
---
gdb/dwarf2-frame-tailcall.c | 2 +-
gdb/dwarf2loc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/dwarf2-frame-tailcall.c b/gdb/dwarf2-frame-tailcall.c
index b412a5b..f964ab2 100644
--- a/gdb/dwarf2-frame-tailcall.c
+++ b/gdb/dwarf2-frame-tailcall.c
@@ -197,7 +197,7 @@ pretended_chain_levels (struct call_site_chain *chain)
return chain->length;
chain_levels = chain->callers + chain->callees;
- gdb_assert (chain_levels < chain->length);
+ gdb_assert (chain_levels <= chain->length);
return chain_levels;
}
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index d811106..29b265b 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -827,7 +827,7 @@ chain_candidate (struct gdbarch *gdbarch, struct call_site_chain **resultp,
PC again. In such case there must be two different code paths to reach
it, therefore some of the former determined intermediate PCs must differ
and the unambiguous chain gets shortened. */
- gdb_assert (result->callers + result->callees < result->length);
+ gdb_assert (result->callers + result->callees <= result->length);
}
/* Create and return call_site_chain for CALLER_PC and CALLEE_PC. All the
--
2.4.0
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next reply other threads:[~2015-05-09 18:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 18:57 Andreas Schwab [this message]
2015-05-13 14:01 ` Jan Kratochvil
2015-05-13 14:35 ` Andreas Schwab
2015-05-29 9:31 ` Yao Qi
2015-05-29 11:31 ` Jan Kratochvil
2015-05-29 13:43 ` Yao Qi
2015-05-29 14:10 ` Jan Kratochvil
2015-05-29 16:33 ` Yao Qi
2015-05-30 7:44 ` Jan Kratochvil
2015-06-01 11:35 ` Yao Qi
2015-06-01 12:05 ` [commit] " Jan Kratochvil
2015-05-19 20:47 ` [patch] testcase: tailcall assertion [Re: [PATCH] Fix wrong assertions] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbg1eg08.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox