From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32502 invoked by alias); 17 Jun 2016 12:36:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32490 invoked by uid 89); 17 Jun 2016 12:36:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 17 Jun 2016 12:36:34 +0000 Received: (qmail 9049 invoked by uid 0); 17 Jun 2016 12:36:30 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy6.mail.unifiedlayer.com with SMTP; 17 Jun 2016 12:36:30 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 7ocP1t00T2f2jeq01ocSpS; Fri, 17 Jun 2016 06:36:28 -0600 X-Authority-Analysis: v=2.1 cv=ff4+lSgF c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=yYlUzDxIT6AA:10 a=pD_ry4oyNxEA:10 a=obZn1TKPyyYHSBzeq8MA:9 Received: from [109.144.250.197] (port=41232 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bDt0a-0000zw-VE; Fri, 17 Jun 2016 06:36:25 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Yao Qi , gdb-patches@sourceware.org Subject: Re: [RFA 3/3] Move logic out of symbol_find_demangled_name References: <1465051760-25840-1-git-send-email-tom@tromey.com> <1465051760-25840-4-git-send-email-tom@tromey.com> <86mvmywgj1.fsf@gmail.com> <8760tl6xbf.fsf@tromey.com> <9b062e13-3541-b122-2da8-1c61fe7fe55b@redhat.com> <871t496nk4.fsf@tromey.com> <7c3ef506-e9f3-968d-c192-c67c99e00269@redhat.com> <874m8sp6dh.fsf@tromey.com> <9a9f6440-f369-d729-71ff-ea961aac3100@redhat.com> Date: Fri, 17 Jun 2016 12:36:00 -0000 In-Reply-To: <9a9f6440-f369-d729-71ff-ea961aac3100@redhat.com> (Pedro Alves's message of "Fri, 17 Jun 2016 13:25:54 +0100") Message-ID: <87vb18ngak.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 109.144.250.197 authed with tom+tromey.com} X-Exim-ID: 1bDt0a-0000zw-VE X-Source-Sender: (pokyo) [109.144.250.197]:41232 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-06/txt/msg00301.txt.bz2 Pedro> OK. I still think we should have a comment clarifying this. Pedro> The new comment mentions that we'll attempt demangling in the Pedro> order the constants are defined, but doesn't explain the Pedro> dependencies that led to the particular order you chose. I added one in language.h but I can move it to enum language instead. Tom