From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34849 invoked by alias); 10 Oct 2016 23:06:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34328 invoked by uid 89); 10 Oct 2016 23:06:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=growing, Hx-spam-relays-external:cmgw3, Hx-spam-relays-external:10.0.90.84, H*RU:10.0.90.84 X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 10 Oct 2016 23:06:35 +0000 Received: (qmail 8065 invoked by uid 0); 10 Oct 2016 23:06:33 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy8.mail.unifiedlayer.com with SMTP; 10 Oct 2016 23:06:33 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id tz6N1t0122f2jeq01z6R9y; Mon, 10 Oct 2016 17:06:25 -0600 X-Authority-Analysis: v=2.1 cv=KLfJUj1o c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=tNzkZYKRtx3g7I5fqBIA:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:50938 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1btjeI-0006Dp-Ey; Mon, 10 Oct 2016 17:06:22 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 06/22] Introduce scoped_minimal_symbol_reader References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-7-git-send-email-tom@tromey.com> <8343d689-83b9-646f-6503-d4d19a3d52ba@redhat.com> Date: Mon, 10 Oct 2016 23:06:00 -0000 In-Reply-To: <8343d689-83b9-646f-6503-d4d19a3d52ba@redhat.com> (Pedro Alves's message of "Thu, 6 Oct 2016 02:09:57 +0100") Message-ID: <87vawzolcj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1btjeI-0006Dp-Ey X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya) [71.218.192.86]:50938 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00237.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> GCC eschews using // comments, to avoid ending up with a mixbag Pedro> of styles. Maybe we should follow suit? I don't remember - did you want me to change this or not? I prefer "//" comments but it's up to you. >> +class scoped_minimal_symbol_reader Pedro> Seems like this is growing to be _the_ reader in following patches? Pedro> I'm wondering whether the "scoped_" prefix will make sense going Pedro> forward. I made this change. Thank goodness for git filter-branch. Tom