From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80612 invoked by alias); 3 May 2017 17:28:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80601 invoked by uid 89); 3 May 2017 17:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1584 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 May 2017 17:27:58 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F21680041; Wed, 3 May 2017 17:27:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3F21680041 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3F21680041 Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14FB353; Wed, 3 May 2017 17:27:58 +0000 (UTC) From: Sergio Durigan Junior To: John Baldwin Cc: GDB Patches , Pedro Alves , Simon Marchi Subject: Re: [PATCH v2 2/2] Rearrange gdb/configure.nat to make it simpler and less redundant References: <20170425202309.15771-1-sergiodj@redhat.com> <20170503034931.4515-1-sergiodj@redhat.com> <20170503034931.4515-3-sergiodj@redhat.com> <13974428.RlsgoICUZ5@ralph.baldwin.cx> X-URL: https://sergiodj.net Date: Wed, 03 May 2017 17:28:00 -0000 In-Reply-To: <13974428.RlsgoICUZ5@ralph.baldwin.cx> (John Baldwin's message of "Wed, 03 May 2017 09:34:06 -0700") Message-ID: <87vaphetpd.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00070.txt.bz2 On Wednesday, May 03 2017, John Baldwin wrote: > On Tuesday, May 02, 2017 11:49:31 PM Sergio Durigan Junior wrote: >> The previous commit introduced gdb/configure.nat, but it was just a >> copy-and-past (with the necessary adjustments) from the files under >> gdb/config/. We can do better than that. >> >> Instead of using one big 'case' statement that matches the >> ${gdb_host_cpu} and then match each ${gdb_host}, it is possible to >> remove a lof of redundancy by matching the most common ${gdb_host}'s >> first, setting the common variables for each, and then proceed to >> matching specific ${gdb_host}'s and ${gdb_host_cpu}'s. In other >> words, reverse the order of the 'case's and take advantage of the fact >> that a lot of parameters are the same for each host. >> >> This commit was tested on x86_64 without regressions. > > Thanks. Just one minor nit that I see: > >> + fbsd) >> + case ${gdb_host_cpu} in >> + i386) >> + # Host: FreeBSD/i386 >> + NATDEPFILES="${NATDEPFILES} x86-nat.o x86-dregs.o \ >> + x86-bsd-nat.o i386-bsd-nat.o i386-fbsd-nat.o bsd-kvm.o" >> + NAT_FILE='nm-fbsd.h' >> + ;; >> + mips) >> + # Host: FreeBSD/mips >> + NATDEPFILES="${NATDEPFILES} mips-fbsd-nat.o" >> + HAVE_NATIVE_GCORE_HOST=1 > > This seems redundant as it is set in the "global" fbsd section? You're right, John. Fixed in my local tree. Thanks for the review, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/