From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104651 invoked by alias); 21 Jun 2017 21:32:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104317 invoked by uid 89); 21 Jun 2017 21:32:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1111 X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 21:32:10 +0000 From: Sergio Durigan Junior To: Pedro Alves Cc: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] environ-selftests: Ignore -Wself-move warning References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> <1498076108-29914-2-git-send-email-simon.marchi@ericsson.com> <87mv91ccey.fsf@sergiodj.net> <884719ed975085085337b2972a9c2ac4@polymtl.ca> Date: Wed, 21 Jun 2017 21:32:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 21 Jun 2017 22:28:37 +0100") Message-ID: <87vanpauy3.fsf@sergiodj.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-06/txt/msg00618.txt.bz2 On Wednesday, June 21 2017, Pedro Alves wrote: > On 06/21/2017 10:05 PM, Simon Marchi wrote: > >> Yeah, I didn't expect to have to put the #ifdefs for __clang__ though. >> Without them, gcc emits a warning [-Wunknown-pragma]. We always have >> the option to turn -Wunknown-pragma off globally, what do you prefer? >> > > Don't both GCC and Clang understand "#pragma GCC diagnostic" instead? > > Or better even, wrap it in some macros (and use _Pragma): > > #define DIAGNOSTIC_PUSH _Pragma ("GCC diagnostic push") > #define DIAGNOSTIC_POP _Pragma ("GCC diagnostic pop") > #define DIAGNOSTIC_IGNORE(option) \ > _Pragma (STRINGIFY (GCC diagnostic ignored option)) > > > Alternatively, you could replace the std::move with a cast > to rvalue ref, which is just what std::move really is: > > -env = std::move (env); > +env = static_cast (env); I don't like this cast TBH. std::move is more readable. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/