From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79948 invoked by alias); 23 Sep 2017 04:14:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79939 invoked by uid 89); 23 Sep 2017 04:14:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Sep 2017 04:14:15 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 794AC1E0796 for ; Fri, 22 Sep 2017 22:14:14 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id CsEB1w01K2f2jeq01sEEUd; Fri, 22 Sep 2017 22:14:14 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=QyXUC8HyAAAA:8 a=8QmBjBdaXyAqRb2W2HUA:9 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:39042 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dvbpT-002dMy-8g; Fri, 22 Sep 2017 22:14:11 -0600 From: Tom Tromey To: "Metzger\, Markus T" Cc: Tom Tromey , "gdb-patches\@sourceware.org" Subject: Re: [RFA 01/67] Add add_cmd function overloads References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-2-tom@tromey.com> Date: Sat, 23 Sep 2017 04:14:00 -0000 In-Reply-To: (Markus T. Metzger's message of "Thu, 21 Sep 2017 07:02:08 +0000") Message-ID: <87vakagigf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dvbpT-002dMy-8g X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:39042 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00719.txt.bz2 >>>>> "Markus" == Metzger, Markus T writes: >> static void >> +do_const_cfunc (struct cmd_list_element *c, char *args, int from_tty) >> +{ >> + c->function.const_cfunc (args, from_tty); /* Ok. */ >> +} Markus> Ok.? This is copy-and-paste from the other function like this. I think this is some way to suppress ARI warnings. I don't know if ARI is still used...? Markus> We shouldn't really have the NULL case, anymore. It is still possible Markus> but I don't expect it to be used. Should we assert CFUNC != NULL? I did this. Tom