From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122935 invoked by alias); 9 Oct 2017 21:58:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122452 invoked by uid 89); 9 Oct 2017 21:58:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:windows, 5.3.0, encrypted, H*r:sk:unused- X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 21:58:08 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6D8044ACA5; Mon, 9 Oct 2017 21:58:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6D8044ACA5 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4558067CE3; Mon, 9 Oct 2017 21:58:07 +0000 (UTC) From: Sergio Durigan Junior To: asmwarrior Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [pushed] Fix more GDB build breakage on mingw32 (Re: [PATCH v5 2/3] Implement "set cwd" command on GDB) References: <20170912042325.14927-1-sergiodj@redhat.com> <20170929225852.21872-1-sergiodj@redhat.com> <20170929225852.21872-3-sergiodj@redhat.com> <874lrg5goz.fsf@redhat.com> <6520ea6a-6be7-db93-1d3e-1b156bc95564@redhat.com> <87mv5841qt.fsf@redhat.com> <87y3osxj6i.fsf@redhat.com> <871smkxaco.fsf@redhat.com> <22dfe787-0c70-b2c1-c1b0-752d2e712f42@redhat.com> <83lgkrzd23.fsf@gnu.org> <87k20bwiis.fsf@redhat.com> <21e02d72-ed9c-5e63-5981-00ec92908257@gmail.com> Date: Mon, 09 Oct 2017 21:58:00 -0000 In-Reply-To: (asmwarrior@gmail.com's message of "Fri, 6 Oct 2017 19:15:01 +0800") Message-ID: <87vajohtld.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00239.txt.bz2 On Friday, October 06 2017, asmwarrior@gmail.com wrote: > On 10/6/2017 7:06 PM, Pedro Alves wrote: >> On 10/06/2017 11:54 AM, Pedro Alves wrote: >> >>> Pushed as below. Thanks. >> Pushed this as well. >> >> From a1b85d282f408dfd18a27539874846197f7e4044 Mon Sep 17 00:00:00 2001 >> From: Pedro Alves >> Date: Fri, 6 Oct 2017 11:58:56 +0100 >> Subject: [PATCH] Fix more GDB build breakage on mingw32 >> >> With F23's mingw gcc 5.3.0, I'm seeing: >> >> i686-w64-mingw32-g++ -x c++ -std=gnu++11 -g3 -O0 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../../src/gdb/../zlib -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib/import -Ibuild-gnulib/import -I/home/pedro/src/expat/install-win32//include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -Werror -c -o windows-nat.o -MT windows-nat.o -MMD -MP -MF ./.deps/windows-nat.o.Tpo ../../src/gdb/windows-nat.c >> ../../src/gdb/windows-nat.c: In function 'void windows_create_inferior(target_ops*, const char*, const string&, char**, int)': >> ../../src/gdb/windows-nat.c:2476:7: error: 'replace' is not a member of 'std' >> std::replace (expanded_infcwd.begin (), expanded_infcwd.end (), >> ^ >> >> gdb/Changelog: >> 2017-10-06 Pedro Alves >> >> * windows-nat.c: Include . >> --- >> gdb/ChangeLog | 4 ++++ >> gdb/windows-nat.c | 1 + >> 2 files changed, 5 insertions(+) >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index 0f92439..559c3b8 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,3 +1,7 @@ >> +2017-10-06 Pedro Alves >> + >> + * windows-nat.c: Include . >> + >> 2017-10-06 Yao Qi >> >> * configure.tgt (i386_tobjs): New variable. >> diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c >> index 1ef38fb..98c32d8 100644 >> --- a/gdb/windows-nat.c >> +++ b/gdb/windows-nat.c >> @@ -42,6 +42,7 @@ >> #include >> #include >> #endif >> +#include >> >> #include "buildsym.h" >> #include "filenames.h" > > > Hi, Pedro Alves, thanks for verifying the changes. > > Aha, I also have this patch fixed in my local git repo, but I just forgot to submit it, because I have locally a lot of other changes. :-) Sorry about the breakage. I guess I forgot to recompile my local tree with mingw after I implemented some improvements to the Windows support. This reminds me that it's a good idea to have a mingw builder in our BuildBot (just building, not testing). I'll see about implementing this. Thank you and Pedro for catching and fixing the issues. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/