From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44807 invoked by alias); 10 Jan 2018 16:14:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44797 invoked by uid 89); 10 Jan 2018 16:14:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.196.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jan 2018 16:14:28 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 0A9574167247B for ; Wed, 10 Jan 2018 10:14:27 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZJ1Gezrm0cGlpZJ1Ge7DO6; Wed, 10 Jan 2018 10:14:27 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:36546 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eZJ1G-000b9O-O6; Wed, 10 Jan 2018 10:14:26 -0600 From: Tom Tromey To: Yao Qi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 3/6] Allocate dwarf2_cu with new References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-4-tom@tromey.com> <861sixhprf.fsf@gmail.com> Date: Wed, 10 Jan 2018 16:14:00 -0000 In-Reply-To: <861sixhprf.fsf@gmail.com> (Yao Qi's message of "Wed, 10 Jan 2018 12:17:24 +0000") Message-ID: <87vag9itcu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eZJ1G-000b9O-O6 X-Source-Sender: 71-218-90-63.hlrn.qwest.net (pokyo) [71.218.90.63]:36546 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-01/txt/msg00201.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> Add "explicit"? I made this change. >> + ~dwarf2_cu (); >> + >> + DISABLE_COPY_AND_ASSIGN (dwarf2_cu); >> + >> + void free_abbrev_table (); Yao> Move comments to dwarf2_free_abbrev_table here? This is gone with Simon's changes; I'll update the ChangeLog and send the updated patch. Tom