From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3368 invoked by alias); 3 Jul 2018 17:43:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3351 invoked by uid 89); 3 Jul 2018 17:43:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nicely, simon.marchi@ericsson.com, simonmarchiericssoncom X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jul 2018 17:43:11 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 89C572859A4 for ; Tue, 3 Jul 2018 12:43:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id aPKGffWMC79N3aPKQf4duI; Tue, 03 Jul 2018 12:43:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ORAZoixVQUNZav20qfr0/kgZqTCGr4Z8GE3f15lggGA=; b=LG7ATXwQI1nxnlp1Aq3BSoDY4U 6pFDbhlX6/Si4GAVIMhh5lbRyyO1kCJqnHwZ1ctFgb7LY0xTk7P+PGTBHGOmcJQzb7powAJXBOI// R5R6YuGkgJdQgPaKgjM43VcKX; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:49352 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1faPKG-0002C9-1l; Tue, 03 Jul 2018 12:42:52 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , Subject: Re: [RFA] Make macOS build warning-free References: <20180629165453.22888-1-tom@tromey.com> <87woudofal.fsf@tromey.com> <5f9b4ce1-aa8d-30e3-98f9-f2c36c3869c6@simark.ca> <87k1qco3vk.fsf@tromey.com> <06af645c-3385-7f78-5aa8-d48566c66a45@ericsson.com> Date: Tue, 03 Jul 2018 17:43:00 -0000 In-Reply-To: <06af645c-3385-7f78-5aa8-d48566c66a45@ericsson.com> (Simon Marchi's message of "Tue, 3 Jul 2018 11:57:55 -0400") Message-ID: <87va9wmd0k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00060.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Indeed. I started a prototype, it uncovered an issue about reread_symbol accessing Simon> objfile::section_offsets out of bounds, so I'm stuck on that. That sounds bad! >> I think the symfile.c change isn't enough, btw; the >> -Wno-deprecated-declarations bit is also required. Otherwise there is at >> least one error (about the use of syscall). But maybe I could disable that >> one with a #pragma instead - what do you think? Simon> About this part, I would prefer if we disabled the warning at the call sites Simon> instead of disabling the warning across the board, since the warning could be relevant Simon> sometimes. Or maybe we should look at using a non-deprecated alternative... Simon> Here's the other patch I've been carrying. If you think it's good, I can finish Simon> it and push it, or you can steal it. Simon> + DIAGNOSTIC_PUSH Simon> + DIAGNOSTIC_IGNORE_DEPRECATED_DECLARATIONS Simon> res = syscall (SYS___pthread_kill, thread->gdb_port, nsignal); Simon> + DIAGNOSTIC_POP I like it but I wonder if it would work with ";" on those lines. That would make indentation work more nicely in Emacs :) Simon> #ifdef HAVE_SBRK Simon> +DIAGNOSTIC_PUSH Simon> +DIAGNOSTIC_IGNORE_DEPRECATED_DECLARATIONS Simon> /* Set this before constructing scoped_command_stats. */ Simon> lim_at_start = (char *) sbrk (0); Simon> +DIAGNOSTIC_POP Simon> #endif Perhaps we need an sbrk wrapper so we can limit the damage to a single spot. Tom