From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106810 invoked by alias); 14 Jul 2018 12:37:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106795 invoked by uid 89); 14 Jul 2018 12:37:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=get_number X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.62.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 12:37:45 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 4A72F400CC26E for ; Sat, 14 Jul 2018 07:37:43 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eJntfZPK4bXuJeJnwfhrg3; Sat, 14 Jul 2018 07:37:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RoZTYCZl1MOIpM+QZkJhVhWfQOGfZD45Q8kwM4x+P1A=; b=KUSnvfrZqfICF0+XwAXF60BfJL u3IKcHSL63L5vxehxNxDHl3nmQdLYCBxus1rYoMFM8GZbK4MkELWxKhNKUwBl3R54z27hJV05r6Hl hAa2JNbRY2d3PycL3cgJd1NBe; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:35128 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1feJnt-004EWJ-3f; Sat, 14 Jul 2018 07:37:37 -0500 From: Tom Tromey To: Simon Marchi Cc: Philippe Waroquiers , gdb-patches@sourceware.org, Tom Tromey Subject: Re: [RFA_v4 2/8] Implement frame apply [all | COUNT | -COUNT | level LEVEL... ] [FLAG]... COMMAND. References: <20180710213926.32240-1-philippe.waroquiers@skynet.be> <20180710213926.32240-3-philippe.waroquiers@skynet.be> <8cb0cf0e-7b41-407b-3ba1-6a7be1a65417@simark.ca> Date: Sat, 14 Jul 2018 12:37:00 -0000 In-Reply-To: <8cb0cf0e-7b41-407b-3ba1-6a7be1a65417@simark.ca> (Simon Marchi's message of "Fri, 13 Jul 2018 21:49:32 -0400") Message-ID: <87va9i9enk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00447.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Hi Philippe, Simon> On 2018-07-10 05:39 PM, Philippe Waroquiers wrote: >> +/* Implementation of the "frame apply level" command. */ >> + >> +static void >> +frame_apply_level_command (const char *cmd, int from_tty) >> +{ >> + if (!target_has_stack) >> + error (_("No stack.")); >> + >> + bool level_found = false; >> + const char *levels_str = cmd; >> + number_or_range_parser levels (levels_str); >> + >> + /* Skip the LEVEL list to find the flags and command args. */ >> + while (!levels.finished ()) >> + { >> + const int level_beg = levels.get_number (); Simon> This variable is unused, so is caught by Tom's -Wunused-variable patch. Simon> Is it just ok to remove the local variable and the assignment (but keep Simon> the call)? That's what I have in my most recent patch. get_number advances through the arguments, so it must be called. But, the result isn't used in this loop, but rather when the arguments are re-parsed later. Tom