From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42251 invoked by alias); 28 Aug 2018 17:43:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42238 invoked by uid 89); 28 Aug 2018 17:43:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 17:43:49 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 0699768652F for ; Tue, 28 Aug 2018 12:43:48 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ui1rf7z5ZRPojui1rfY9pQ; Tue, 28 Aug 2018 12:43:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yQwPLUuFjYsFd1SqpZywOzkWSVxPy7DeVMhSMtriqDo=; b=KAyY3lu2sXKfC+PP/hk6+tlG6X 2O4Gy04O6XiQLF2NTCvPXA/MJ8I/ihZGWDV+iBtbcJvlirMoan7yIXmHqBJjeHvrHKK8qUSG4fuLM MOZzOQJDt5YbWMl+GLK30+dYN; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47962 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fui1r-001xFA-PK; Tue, 28 Aug 2018 12:43:47 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/9] Change `function_symbols' to std::vector References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-3-keiths@redhat.com> <8736vlufef.fsf@tromey.com> <4ebc660f-80ae-675b-118f-0a8cb859a3a8@redhat.com> Date: Tue, 28 Aug 2018 17:43:00 -0000 In-Reply-To: <4ebc660f-80ae-675b-118f-0a8cb859a3a8@redhat.com> (Keith Seitz's message of "Fri, 17 Aug 2018 10:59:21 -0700") Message-ID: <87va7u5qul.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00699.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> I know you approved this, but based on feedback on the minimal_symbols patch Keith> (#4 in this series), I thought I would also switch to sorting function_symbols Keith> with std::sort instead of qsort. Keith> This does involve introducing a new "std_compare_symbols" function since the Keith> one remaining qsort cannot be eliminated until later. [By the end of the Keith> series, though, we will be back to one Compare function again.] Keith> This is the only change in this revision. Thanks, this is ok. It's always fine to push back on a review, like in this case if it was simpler to tack on a patch to convert to std::sort, rather than fixing it mid-stream, that would have been fine. Tom