From: Tom Tromey <tom@tromey.com>
To: John Darrington <john@darrington.wattle.id.au>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] GDB: Add support for 24 bit addresses
Date: Fri, 07 Sep 2018 22:04:00 -0000 [thread overview]
Message-ID: <87va7hufpz.fsf@tromey.com> (raw)
In-Reply-To: <20180829141845.26378-4-john@darrington.wattle.id.au> (John Darrington's message of "Wed, 29 Aug 2018 16:18:44 +0200")
>>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:
John> * gdb/dwarf2-frame.c (encoding_for_size): Deal with case 3.
John> (read_encoded_value): Deal with case DW_EH_PE_udata3
This is ok; pending the dwarf2.h patch of course.
John> default:
John> - internal_error (__FILE__, __LINE__, _("Unsupported address size"));
John> + internal_error (__FILE__, __LINE__, _("Unsupported address size %d"), size);
Thanks for doing that.
Tom
next prev parent reply other threads:[~2018-09-07 22:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 14:18 S12Z [new patchset] John Darrington
2018-08-29 14:18 ` [PATCH 1/4] gdb: Add builtin types for 24 bit integers John Darrington
2018-09-07 22:04 ` Tom Tromey
2018-09-08 4:27 ` John Darrington
2018-09-08 5:56 ` Tom Tromey
2018-08-29 14:18 ` [PATCH 3/4] GDB: Add support for 24 bit addresses John Darrington
2018-09-07 22:04 ` Tom Tromey [this message]
2018-08-29 14:19 ` [PATCH 4/4] GDB: New target s12z John Darrington
2018-09-07 22:03 ` Tom Tromey
2018-09-08 4:46 ` John Darrington
2018-09-08 13:16 ` Tom Tromey
2018-09-08 13:21 ` John Darrington
2018-08-29 14:19 ` [PATCH 2/4] Add a dwarf unit type to represent 24 bit values John Darrington
2018-09-07 21:50 ` Tom Tromey
2018-09-26 17:42 ` John Darrington
2018-09-27 2:53 ` Simon Marchi
2018-09-27 5:49 ` John Darrington
2018-09-27 17:53 ` Simon Marchi
2018-09-28 16:03 ` John Darrington
2018-09-07 22:46 ` S12Z [new patchset] Simon Marchi
2018-09-08 4:18 ` John Darrington
2018-09-08 6:30 ` John Darrington
2018-09-08 21:37 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va7hufpz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox