From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110707 invoked by alias); 22 Feb 2019 17:04:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110689 invoked by uid 89); 22 Feb 2019 17:04:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Built X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Feb 2019 17:04:33 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway32.websitewelcome.com (Postfix) with ESMTP id DDB1516244B for ; Fri, 22 Feb 2019 11:04:12 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xEFAgtpOf2PzOxEFAgLlQ9; Fri, 22 Feb 2019 11:04:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U3b/ERLw4t/6I1Gf7QThCsWSyrotTlrWfAgG33vqY4s=; b=xKbhGFKCrAMX395UERcMKXVzWA e9bsxIFPG/sEG3WGcAAi+TtYOZUdnLmuCbvog85xCrTldfoeLc5Sh8Qkei3C9QmyVVIEsNNzdozFj w6NKR3Lo5VjW0MkPoOvmnka//; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:49586 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gxEFA-000DGU-6B; Fri, 22 Feb 2019 11:04:12 -0600 From: Tom Tromey To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix coff_start_symtab resource leak found by Coverity References: <1550848393-2743-1-git-send-email-gbenson@redhat.com> Date: Fri, 22 Feb 2019 17:04:00 -0000 In-Reply-To: <1550848393-2743-1-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Fri, 22 Feb 2019 15:13:13 +0000") Message-ID: <87va1b69h1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00361.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> Hi all, Gary> This commit fixes a resource leak found by Coverity, where Gary> coff_start_symtab performs an xstrdup that is now performed Gary> within start_symtab by buildsym_compunit::buildsym_compunit. Gary> Built and regtested on RHEL 7.6 x86_64. Gary> Ok to commit? Yes, thank you. Tom